fix(ci): remove fvm use --force from firebase-hosting workflows#72
Closed
leoafarias wants to merge 1 commit into
Closed
fix(ci): remove fvm use --force from firebase-hosting workflows#72leoafarias wants to merge 1 commit into
leoafarias wants to merge 1 commit into
Conversation
The pre-install via `fvm use --force` creates a .fvm/flutter_sdk pointing at FVM's own checkout (lacking a proper engine.stamp). The later `ln -sfn "$FLUTTER_ROOT" .fvm/flutter_sdk` does not fully replace it, so melos bootstrap calls FVM's Flutter and pub fails with a 404 on engine_stamp.json (empty version segment in the URL). test.yml passes without this pre-install; matching that pattern restores the firebase-hosting builds.
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Collaborator
Author
|
Superseded by PR #70 — the fix was cherry-picked onto that branch (commit f072aa2) so it could verify against the build_and_preview job (which is gated on packages/** changes). Verification run: https://github.com/btwld/superdeck/actions/runs/25755621851/job/75643153365 — passed in 5m41s. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the
fvm use --forceline from both firebase-hosting workflows (firebase-hosting-merge.yml,firebase-hosting-pull-request.yml).Why
The
build_and_previewjob has been failing on every PR from the main repo, while thetest.ymlworkflows (Test, Integration Tests, Web Smoke) pass — same.fvmrc, samekuhnroyal/flutter-fvm-config-action@v2, samesubosito/flutter-action@v2. The only meaningful difference is the firebase-hosting workflows' extrafvm use --forceline in the Install FVM step.fvm use --forcepre-creates.fvm/flutter_sdkpointing at FVM's own checkout, which lacks a properbin/internal/engine.stamp. The laterln -sfn "\$FLUTTER_ROOT" .fvm/flutter_sdkapparently does not fully replace that pre-existing symlink, somelos bootstrapends up calling FVM's Flutter forpackages/superdeck. Pub then fails resolving engine info:(Double slash = empty version segment.) Other packages succeed because they are pure Dart and do not trigger engine resolution.
Aligning these workflows with
test.yml(nofvm use --force) fixes the build.Test plan
build_and_previewsucceeds on this PRpackages/superdeckwithout 404 on engine_stamp.json