Add support for scientific notation with 'e' and 'E'#97
Open
kohlerdominik wants to merge 1 commit intobugwheels94:masterfrom
Open
Add support for scientific notation with 'e' and 'E'#97kohlerdominik wants to merge 1 commit intobugwheels94:masterfrom
kohlerdominik wants to merge 1 commit intobugwheels94:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #96, describing that scientific notation (e.g.,
1e-7,1e+7) is incorrectly parsed as an arithmetic operation involving the Euler constante.Changes
1. Lexer Look-ahead Logic
Modified
src/lexer.tsto implement a look-ahead check. When the lexer encounterseorEpreceded by a number, it now checks for:1e7)1e-7or1e+7)If these patterns match, they are collapsed into the
NUMBERtoken instead of being treated as constants or operators.2. Capital
ESupportAdded
Eas a valid token insrc/token.tsfor parity withe, allowing1E-7to be parsed correctly.3. Euler Constant Preservation
Standalone usage of the constant
eremains unaffected. The lexer only triggers the scientific notation logic if theeis immediately preceded by a numeric value.4. New Test Suite
Added
test/scientific-notation.jswith 11 test cases.