fix: BYT-8268 - require CALL keyword at SQL level and fix related grammar issues #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmar issues This commit addresses BYT-8268 by making the CALL keyword mandatory at SQL statement level while keeping it optional at PL/SQL block level, and fixes grammar issues that were previously hidden by optional CALL. Changes: 1. Split call_statement into two rules: - sql_call_statement: CALL keyword MANDATORY (SQL level) - plsql_call_statement: CALL keyword OPTIONAL (PL/SQL block level) 2. Support method chaining in CALL statements: - CALL obj_constructor(...).method(...) INTO :var 3. Fix commit_statement to allow WRITE clause independently: - Previously: COMMIT [COMMENT 'text' [WRITE ...]] - Now: COMMIT [COMMENT 'text'] [WRITE ...] 4. Fix link_name to support qualified database links: - Now supports: @schema.linkname or @linkname.domain 5. Fix system_action to support multi-word actions: - Added: ADMINISTER KEY MANAGEMENT - Added: General patterns for 2-3 word actions Why these changes: - The optional CALL keyword caused keywords like CASCADE to be misidentified as procedure calls, leading to incorrect SQL splitting - At SQL level, Oracle requires CALL keyword - At PL/SQL block level, Oracle allows direct procedure invocation - The fixes to COMMIT, link_name, and system_action address grammar deficiencies that were previously hidden by the optional CALL Tests: All 600+ parser tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses BYT-8268 by making the CALL keyword mandatory at SQL statement level while keeping it optional at PL/SQL block level, and fixes grammar issues that were previously hidden by optional CALL.
Changes:
Split call_statement into two rules:
Support method chaining in CALL statements:
Fix commit_statement to allow WRITE clause independently:
Fix link_name to support qualified database links:
Fix system_action to support multi-word actions:
Why these changes:
Tests: All 600+ parser tests pass
🤖 Generated with Claude Code