refactor(plsql): remove unused rules and replace some literal with token symbol for plsql parser #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 43 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | DROP DIRECTORY filename force_noforce? (','filename force_noforce?)* | ||
| | RENAME DIRECTORY dir_name TO dir_name (',' dir_name TO dir_name)* | ||
| : ADD DIRECTORY filename (COMMA filename)* | ||
| | DROP DIRECTORY filename force_noforce? (COMMAfilename force_noforce?)* |
There was a problem hiding this comment.
Missing space between COMMA and filename in the replacement. This should be COMMA filename instead of COMMAfilename.
Suggested change
| | DROP DIRECTORY filename force_noforce? (COMMAfilename force_noforce?)* | |
| | DROP DIRECTORY filename force_noforce? (COMMA filename force_noforce?)* |
h3n4l
added a commit
to bytebase/bytebase
that referenced
this pull request
Nov 13, 2025
Introducing the following commit: bytebase/parser#41 bytebase/parser#40 bytebase/parser#39
h3n4l
added a commit
to bytebase/bytebase
that referenced
this pull request
Nov 17, 2025
Introducing the following commit: bytebase/parser#41 bytebase/parser#40 bytebase/parser#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.