Skip to content

🎨 Palette: Add accessibility and tooltips to NodeModulesSection header#231

Open
acebytes wants to merge 2 commits into
mainfrom
palette/nodemodules-a11y-13643687145363839748
Open

🎨 Palette: Add accessibility and tooltips to NodeModulesSection header#231
acebytes wants to merge 2 commits into
mainfrom
palette/nodemodules-a11y-13643687145363839748

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented May 9, 2026

💡 What: Added accessibility labels, values, traits, and a help tooltip to the collapsible NodeModulesSection header.
🎯 Why: To clearly indicate to VoiceOver users that the header acts as an expandable/collapsible button and report its current state. The tooltip provides mouse hover context.
📸 Before/After: Visuals remain unchanged, but VoiceOver now correctly reads the button state and label, and hovering over the area shows a tooltip.
Accessibility: Added accessibilityLabel, accessibilityValue, accessibilityAddTraits, and help modifiers.


PR created automatically by Jules for task 13643687145363839748 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@acebytes
Copy link
Copy Markdown
Contributor Author

Heads-up before this gets rebased: the diff removes the three existing .jules/palette.md entries (Clickable List Rows / Icon-only Controls / Empty States in Process Lists) and replaces them with the new NodeModulesSection-header entry. That's because this branch was based on an older palette.md. Rebasing onto current main will cause an add/add conflict — the right resolution is to append the new entry to the existing three, not replace them.

The Swift code change (.accessibilityLabel / .accessibilityValue / .accessibilityAddTraits(.isButton) / .help on the disclosure header) looks correct and aligns with the documented 'Accessibility Modifiers on Icon-only Controls' learning.

@google-labs-jules
Copy link
Copy Markdown
Contributor

Heads-up before this gets rebased: the diff removes the three existing .jules/palette.md entries (Clickable List Rows / Icon-only Controls / Empty States in Process Lists) and replaces them with the new NodeModulesSection-header entry. That's because this branch was based on an older palette.md. Rebasing onto current main will cause an add/add conflict — the right resolution is to append the new entry to the existing three, not replace them.

The Swift code change (.accessibilityLabel / .accessibilityValue / .accessibilityAddTraits(.isButton) / .help on the disclosure header) looks correct and aligns with the documented 'Accessibility Modifiers on Icon-only Controls' learning.

Thank you for the heads-up. I've updated the PR so that the new .jules/palette.md entry is appended to the existing file rather than replacing it to avoid merge conflicts.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant