Skip to content

🎨 Palette: Add accessibility and tooltips to NodeModulesSection header #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acebytes wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🎨 Palette: Add accessibility and tooltips to NodeModulesSection header #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c5af99
Add accessibility and tooltips to NodeModulesSection header
google-labs-jules[bot] May 9, 2026
6db4317
Add accessibility and tooltips to NodeModulesSection header
google-labs-jules[bot] May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,7 @@
## 2024-05-24 - Empty States in Process Lists
**Learning:** Users can misinterpret an empty dynamic list (like processes) as a broken UI or a frozen app if there's no visual feedback indicating that the list is intentionally empty.
**Action:** Always provide a clear, empty state with an icon and brief text for dynamic lists that might temporarily yield no results, preventing user confusion.

## 2024-05-24 - NodeModulesSection Header Accessibility
**Learning:** Disclosure groups built with custom `Button` and `Image` primitives in SwiftUI lack native expand/collapse semantics for VoiceOver, unlike the native `DisclosureGroup` component.
**Action:** When building custom expand/collapse headers, explicitly add `.accessibilityAddTraits(.isButton)`, an `.accessibilityLabel`, an `.accessibilityValue` (Expanded/Collapsed), and a `.help` tooltip.
4 changes: 4 additions & 0 deletions Sources/Cacheout/Views/NodeModulesSection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ struct NodeModulesSection: View {
.contentShape(Rectangle())
}
.buttonStyle(.plain)
.accessibilityLabel("Project node modules")
.accessibilityValue(isExpanded ? "Expanded" : "Collapsed")
.accessibilityAddTraits(.isButton)
.help(isExpanded ? "Collapse node_modules section" : "Expand node_modules section")

if isExpanded && viewModel.isNodeModulesScanning {
HStack {
Expand Down
Loading