Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix process execution deadlock vulnerability#224

Closed
acebytes wants to merge 1 commit into
mainfrom
sentinel/fix-process-deadlock-1447749825474074092
Closed

πŸ›‘οΈ Sentinel: [MEDIUM] Fix process execution deadlock vulnerability#224
acebytes wants to merge 1 commit into
mainfrom
sentinel/fix-process-deadlock-1447749825474074092

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented May 6, 2026

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: A process execution deadlock pattern exists where pipe.fileHandleForReading.readDataToEndOfFile() is called after process.waitUntilExit(), or when standard output is read inside a terminationHandler. If the pipe's buffer fills, the child process blocks on write(), while the parent is blocked on waitUntilExit() or waiting for the terminationHandler, creating a deadlock.
🎯 Impact: May cause the application to hang when running specific external processes such as docker or tmutil, denying service for cleanup or pruning.
πŸ”§ Fix: Refactored to read pipes before waitUntilExit() or asynchronously to avoid deadlock.
βœ… Verification: Ensured code properly reads from pipe before waiting for exit.


PR created automatically by Jules for task 1447749825474074092 started by @acebytes

…process wait

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@acebytes
Copy link
Copy Markdown
Contributor Author

Duplicate β€” splits into two canonicals: #236 (CacheoutViewModel runCleanCommand swap) and #227 (Tier2 SnapshotCleanup readGroup pattern). #227's approach (start readers before process.run(), wait on readGroup in terminationHandler) is cleaner than the inline DispatchQueue rewrite here.

@acebytes acebytes closed this May 17, 2026
@acebytes acebytes deleted the sentinel/fix-process-deadlock-1447749825474074092 branch May 17, 2026 14:33
@google-labs-jules
Copy link
Copy Markdown
Contributor

Duplicate β€” splits into two canonicals: #236 (CacheoutViewModel runCleanCommand swap) and #227 (Tier2 SnapshotCleanup readGroup pattern). #227's approach (start readers before process.run(), wait on readGroup in terminationHandler) is cleaner than the inline DispatchQueue rewrite here.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant