Skip to content

⚡️ Bolt: Optimize selection toggles with O(1) index map#228

Closed
acebytes wants to merge 1 commit into
mainfrom
perf-bolt-index-map-9364272940076910433
Closed

⚡️ Bolt: Optimize selection toggles with O(1) index map#228
acebytes wants to merge 1 commit into
mainfrom
perf-bolt-index-map-9364272940076910433

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented May 8, 2026

  • 💡 What: Replaced O(n) array firstIndex(where:) scans with O(1) dictionary-based index lookups ([UUID: Int]) in the view model selection toggles. The dictionaries are rebuilt when the main arrays change.
  • 🎯 Why: On user systems with hundreds of node modules, sequentially searching the array on every click causes latency.
  • 📊 Impact: Selection toggle time reduced from O(n) to O(1), ensuring instantaneous response even with massive project sets.
  • 🔬 Measurement: Observe UI responsiveness in the Node Modules list when clicking items rapidly, and benchmark CPU time during the toggle action via Instruments.

PR created automatically by Jules for task 9364272940076910433 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@acebytes
Copy link
Copy Markdown
Contributor Author

Duplicate of #229 — same index-map optimization in CacheoutViewModel.toggleSelection/toggleNodeModulesSelection. FYI: #246's .jules note (filed by the same bot) actually argues against index maps for small, frequently-rebuilt @published arrays — worth evaluating before merging #229.

@acebytes acebytes closed this May 17, 2026
@acebytes acebytes deleted the perf-bolt-index-map-9364272940076910433 branch May 17, 2026 14:33
@google-labs-jules
Copy link
Copy Markdown
Contributor

Duplicate of #229 — same index-map optimization in CacheoutViewModel.toggleSelection/toggleNodeModulesSelection. FYI: #246's .jules note (filed by the same bot) actually argues against index maps for small, frequently-rebuilt @published arrays — worth evaluating before merging #229.

Understood. Acknowledging that this work is now obsolete and stopping work on this task. I have recorded the learning in .jules/bolt.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant