Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix fd leak and unsafe path bridging on PID lock#248

Merged
acebytes merged 1 commit into
mainfrom
sentinel-fix-pid-lock-fd-leak-16921181005958822429
May 17, 2026
Merged

πŸ›‘οΈ Sentinel: [MEDIUM] Fix fd leak and unsafe path bridging on PID lock#248
acebytes merged 1 commit into
mainfrom
sentinel-fix-pid-lock-fd-leak-16921181005958822429

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Missing O_CLOEXEC causes the file descriptor to leak to child processes. Implicit path string bridging may not produce a valid file system representation.
🎯 Impact: Child processes could inherit the PID lock file descriptor, preventing the lock from being released on daemon shutdown.
πŸ”§ Fix: Added O_CLOEXEC, used S_IRUSR | S_IWUSR for atomic 0600 mode application, and withUnsafeFileSystemRepresentation for safe string passing.
βœ… Verification: Verified file modifications and executed test suite successfully.


PR created automatically by Jules for task 16921181005958822429 started by @acebytes

@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Calling `open(2)` without `O_CLOEXEC` causes the file descriptor to leak to child processes, which could prevent the PID lock from being released on daemon shutdown. Implicit path string bridging may not produce a valid file system representation. This adds `O_CLOEXEC`, uses `S_IRUSR | S_IWUSR` for atomic 0600 mode application, and `withUnsafeFileSystemRepresentation` for safe string passing.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@acebytes acebytes force-pushed the sentinel-fix-pid-lock-fd-leak-16921181005958822429 branch from 343bcf0 to 05935a5 Compare May 17, 2026 14:38
@acebytes acebytes merged commit 7e7e1e3 into main May 17, 2026
1 check passed
@acebytes acebytes deleted the sentinel-fix-pid-lock-fd-leak-16921181005958822429 branch May 17, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant