⚡ Bolt: Parallelize bulk file deletion to reduce UI blocking#261
⚡ Bolt: Parallelize bulk file deletion to reduce UI blocking#261acebytes wants to merge 1 commit into
Conversation
Refactored `removeContents(of:)` in `CacheCleaner` to perform parallel file deletion using `withThrowingTaskGroup` with a sliding window iterator and `Task.detached`. This significantly speeds up permanent deletion of large cache directories and prevents the actor's thread pool from exhaustion, which could otherwise lead to application blocking. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82458ee295
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try await trashDirectory(url) | ||
| } else { | ||
| try removeContents(of: url) | ||
| try await removeContents(of: url, fileManager: fileManager) |
There was a problem hiding this comment.
Changing permanent deletion from removeContents (sync, actor-isolated) to await removeContents with a nonisolated implementation introduces a suspension point in the clean loop, so CacheCleaner can now interleave another clean request while the first one is still deleting files. If two clean operations overlap (for example, duplicate UI triggers or concurrent callers), both runs can enumerate/delete the same paths and produce spurious ENOENT errors or inconsistent cleanup reports. The previous synchronous path did not permit this interleaving for permanent deletes.
Useful? React with 👍 / 👎.
1 participant
removeContents(of:)inCacheCleanerto perform parallel file deletion usingwithThrowingTaskGroupwith a sliding window iterator andTask.detached.PR created automatically by Jules for task 16464097639330715002 started by @acebytes