Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Process deadlock in Tier2Interventions#264

Open
acebytes wants to merge 1 commit into
mainfrom
fix-tmutil-deadlock-4483427485175968279
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Process deadlock in Tier2Interventions#264
acebytes wants to merge 1 commit into
mainfrom
fix-tmutil-deadlock-4483427485175968279

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

  • 🚨 Severity: CRITICAL
  • πŸ’‘ Vulnerability: A deadlock vulnerability exists in listLocalSnapshots() because it reads stdout and stderr exclusively inside process.terminationHandler.
  • 🎯 Impact: The app will freeze indefinitely when attempting to list time machine snapshots.
  • πŸ”§ Fix: Used DispatchQueue.global().async and DispatchGroup with a thread-safe PipeBuffer wrapper class to concurrently read both pipes safely.
  • βœ… Verification: Manual verification since tests are broken in the environment.

PR created automatically by Jules for task 4483427485175968279 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9461da82a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +752 to +756
readGroup.enter()
DispatchQueue.global(qos: .userInitiated).async {
stdoutBuffer.append(stdoutHandle.readDataToEndOfFile())
readGroup.leave()
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Start pipe readers only after process launch succeeds

These readDataToEndOfFile() tasks are started before process.run(), so if launch fails (for example missing/blocked tmutil or spawn errors), both reads can block waiting for EOF while the pipe write ends remain open on the Process object. That introduces a new failure mode where each launch error leaves background workers hung until later cleanup, which can accumulate and starve threads under repeated failures. Start the readers only after a successful run() (or explicitly close the pipe write handles in the catch path) to avoid this leak/hang path.

Useful? React with πŸ‘Β / πŸ‘Ž.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant