π‘οΈ Sentinel: [CRITICAL] Fix Process deadlock in Tier2Interventions#264
π‘οΈ Sentinel: [CRITICAL] Fix Process deadlock in Tier2Interventions#264acebytes wants to merge 1 commit into
Conversation
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9461da82a7
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| readGroup.enter() | ||
| DispatchQueue.global(qos: .userInitiated).async { | ||
| stdoutBuffer.append(stdoutHandle.readDataToEndOfFile()) | ||
| readGroup.leave() | ||
| } |
There was a problem hiding this comment.
Start pipe readers only after process launch succeeds
These readDataToEndOfFile() tasks are started before process.run(), so if launch fails (for example missing/blocked tmutil or spawn errors), both reads can block waiting for EOF while the pipe write ends remain open on the Process object. That introduces a new failure mode where each launch error leaves background workers hung until later cleanup, which can accumulate and starve threads under repeated failures. Start the readers only after a successful run() (or explicitly close the pipe write handles in the catch path) to avoid this leak/hang path.
Useful? React with πΒ / π.
listLocalSnapshots()because it readsstdoutandstderrexclusively insideprocess.terminationHandler.DispatchQueue.global().asyncandDispatchGroupwith a thread-safePipeBufferwrapper class to concurrently read both pipes safely.PR created automatically by Jules for task 4483427485175968279 started by @acebytes