Constrain classes further in MailPreview controller#1078
Open
markstory wants to merge 1 commit into
Open
Conversation
This controller should not attempt to load classes with `\` in the name, nor should it attempt to load classes that do not extedn `MailPreview`. Thanks to Volker Dusch and the PHP Ecosystem security team for reporting this.
LordSimal
reviewed
Jun 4, 2026
| * @throws \Cake\Http\Exception\NotFoundException | ||
| */ | ||
| protected function findPreview(string $previewName, string $emailName, string $plugin = ''): PreviewResult | ||
| protected function findPreview(string $previewName, string $emailName, ?string $plugin = ''): PreviewResult |
Contributor
There was a problem hiding this comment.
Why does this need to be nullable?
Member
There was a problem hiding this comment.
Using null when the mailer is not from a plugin makes sense, but then the default value of the argument should be null, not empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This controller should not attempt to load classes with
\in the name, nor should it attempt to load classes that do not extednMailPreview.Thanks to Volker Dusch and the PHP Ecosystem security team for reporting this.