fix: add web viewport control and screenshot aliases#865
Merged
Conversation
|
Member
Author
|
Marking this draft for now: issue #864 was updated after this work started. The current ask is no longer missing full-page capture; |
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
Post-merge second-pass note: no blocker found, but there are two small follow-ups now on
These are P3 cleanup items after merge, not a reason to revert #865. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keeps the existing web
--fullscreenscreenshot behavior and makes it discoverable by documenting that--platform webuses it for full-page capture.Adds
--fulland-fas screenshot aliases for parity with agent-browser, and adds a new webviewport <width> <height>command for fixed-layout or100vhapps where changing the viewport is the real missing control.Threads the new viewport command through the public command surface, daemon routing, web interactor/provider path, docs/help, and regression coverage. Closes #864.
Touched files: 34. Scope expanded from the original screenshot command family to one additional web-only management command.
Validation
GitHub CI is green on
7bdccdc23: Lint & Format, Unit Tests, Typecheck, Integration Tests, Smoke Tests, Web Platform Smoke, Coverage, Fallow Code Quality, Bundle Size, CodeQL, and related guards passed.node --test test/integration/smoke-web-platform.test.tspassed locally withAGENT_DEVICE_WEB_E2E=1.Manual built-CLI verification passed against
/private/tmp/issue-864-fixed-layout.htmlusing state dir/private/tmp/agent-device-issue-864:screenshot --fullproduced/private/tmp/issue-864-before.pngat1280x577,viewport 1280 900succeeded, andscreenshot -fthen produced/private/tmp/issue-864-after.pngat1280x900with below-fold content visible only after the viewport resize.node scripts/sync-mcp-metadata.mjs --check,git diff --check,node --experimental-strip-types src/bin.ts help screenshot, andnode --experimental-strip-types src/bin.ts help viewportpassed locally.