fix: fix js bottom tabs crashing on contacts in example#545
Open
chitrakshtarun wants to merge 1 commit into
Open
fix: fix js bottom tabs crashing on contacts in example#545chitrakshtarun wants to merge 1 commit into
chitrakshtarun wants to merge 1 commit into
Conversation
Author
|
Hi @thiagobrez, hope pinging for this is fine! This is my first PR in the repo, have made my best attempts to ensure the CONTRIBUTING.md guidelines are met. Please let me know if the same looks fine, or if I should do any further changes before the PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Bug fix.
Fixes the runtime crash in the JS Bottom Tabs example when switching to the Contacts tab:
Root cause: The Contacts.tsx screen is shared by all example navigators, and was using the
useBottomTabBarHeightimport. This threw because of a missing context in the JS implementation, as it used the JS implementation instead of the Native Implementation.This fix should read from the context safely, and fallback to a nullish coalescence value to prevent any errors.
How to test?
Screenshots
js-bottom-tabs-repro.mov
Closes #533