fix(ios): hide vertical pager scroll edge effects - #1149
Merged
Merged
Conversation
1 of 3 tasks
Collaborator
|
@ArekChr could you test this https://github.com/callstack/react-native-pager-view/releases/tag/v9.0.6 ? |
Contributor
Author
|
@troZee The insets are fixed now, but I can still see the native edge effects overlaying the page content. So the layout itself is correct, but the edge effect is still visible and covers part of the page. |
ArekChr
force-pushed
the
fix/ios-vertical-pager-safe-area
branch
from
October 1, 2026 07:09
b40b95a to
4838bc8
Compare
ArekChr
changed the title
Contributor
Author
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The iOS 26 visual behavior still requires validation on a device or simulator.
Review effort: Balanced
Findings: None
What changed in this PR
Hides rotated iOS 26 scroll-edge effects that obscure vertical pager content.
Changes:
- Hides all collection-view edge effects for vertical pagers on iOS 26+.
- Leaves horizontal pagers and earlier iOS versions unchanged.
| File | Description |
|---|---|
ios/PagerView.swift |
Disables edge effects for rotated vertical pagers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lvlrSajjad
added a commit
to lvlrSajjad/react-native-pager-view
that referenced
this pull request
Oct 1, 2026
Resolve the conflict in ios/PagerView.swift by keeping the iOS 26 edge effect hiding for the vertical pager (callstack#1149) ahead of the once-per-collection-view delegate install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On iOS 26, the native scroll edge effects of a vertical pager can appear sideways over the page content. With v9.0.6, the layout and insets are correct in my app, but this overlay remains visible.
This PR hides the four collection-view edge effects for vertical pagers on iOS 26 and later. It does not change the layout, the public API, or Android behavior. The earlier layout and safe-area changes were removed after rebasing onto v9.0.6; #1150 already covers the root GeometryReader adjustment.
Verification
Screenshots
Reported application screenshots of the issue: