feat(sqlite-plugin): export SQL and bridge helpers for custom adapters#259
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When building a custom SQLite adapter for Rozenite (e.g. a driver not covered by the built-in Expo SQLite adapter), developers need to parse, classify, and normalise SQL statements themselves — and decode bridge-encoded values returned over the JS/native boundary. The relevant utilities already exist in
shared/sqlandshared/bridge-values, but they were not exported from the package, forcing consumers to either duplicate the logic or reach into internal paths.What
Exports the following helpers from the
react-nativeentry-point ofsqlite-plugin:shared/sqlSqlStatementSegment(type)classifySqlStatementnormalizeSingleStatementSqlsplitSqlStatementsstatementReturnsRowsshared/bridge-valuesdecodeSqliteBridgeValueformatSqliteErrorApproach
An earlier attempt at this was made in #226, which tried to generate a new dedicated entry-point for these helpers. That approach turned out to be flaky, so for the time being the same pattern used for all other exported functions is applied here:
letdeclarations assigned via inlinerequire()calls that Metro can statically analyse, with passive no-op mocks assigned in theelsebranch for production/web/SSR builds. This ensures the helpers are completely tree-shaken out of production bundles.