fix(a11y-landmark): spread other html props over tabs nav item#1405
Open
Stefan3002 wants to merge 1 commit into
Open
fix(a11y-landmark): spread other html props over tabs nav item#1405Stefan3002 wants to merge 1 commit into
Stefan3002 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for passing additional HTML/ARIA attributes to the <nav> element rendered by Tabs, to help consumers provide unique accessible names (avoiding “unique landmark” a11y violations when multiple nav landmarks exist).
Changes:
- Spreads remaining props from
Tabsonto the root<nav>element.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
50
to
+54
| const Tabs = <P,>({ | ||
| className, | ||
| links, | ||
| listClassName, | ||
| ...props |
| }: Props<P>): React.JSX.Element => { | ||
| return ( | ||
| <nav className={classNames("p-tabs", className)}> | ||
| <nav className={classNames("p-tabs", className)} {...props}> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
QA
Pinging @canonical/react-library-maintainers for a review.
Make sure that, when you pass in a "aria-label" attribute to the Tabs component, it is actually rendered in the nav element
Storybook
To see rendered examples of all react-components, run:
QA
Fixes
Fixes: #AC-4738