Conversation
The file says it "is referenced with a --bazelrc option in the call to bazel in ci.yaml", but nothing references it: the only mention anywhere in the tree was a pointer comment in //.bazelrc, and it has not been touched since the initial commit. ci.yaml passes its CI settings inline through setup-bazel's bazelrc input instead, so none of these settings have been taking effect. Of what it contained, --announce_rc and --test_output=errors are already set inline in ci.yaml. --disk_cache was never persisted between runs, and its comment claiming the repository cache is deliberately not enabled is contradicted by ci.yaml, which sets repository-cache: true. --test_env=XDG_CACHE_HOME is the only setting not covered elsewhere; it exists to let tests run bazelisk-in-bazel, and there are no such tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.bazelrcopens with:Nothing references it.
grep -rn ci.bazelrcacross the tree found exactly one hit — a pointer comment in//.bazelrc— and the file has not been touched since the initial commit.ci.yamlpasses its CI settings inline throughsetup-bazel'sbazelrcinput instead:So none of the settings in the file have been taking effect. This removes it, along with the now-dangling comment in
//.bazelrc.What was in it, and where it stands
build --announce_rcci.yamltest --test_output=errorsci.yamlbuild --disk_cache=~/.cache/bazeltest --test_env=XDG_CACHE_HOMEThe disk cache entry is also self-contradictory in a way worth noting: its comment says "We do not enable the repository cache to cache downloaded external artifacts as these are generally faster to download again."
ci.yamlsetsrepository-cache: true, so current practice is the opposite of what the file documents.--test_env=XDG_CACHE_HOMEis the one setting not duplicated inci.yaml. Its comment says it exists to let tests run bazelisk-in-bazel; there are no such tests in the repo (no hits forbazeliskorXDG_CACHE_HOMEin any.bzl,BUILD, or shell file), and the suite passes without it — as it has been doing all along, since the file was never applied. If a bazelisk-in-bazel test is added later, that setting can go intoci.yaml's inline block where it will actually apply.Test plan
grep -rn ci.bazelrcacross the tree returns nothingbazel build //examples/wolfi-basesucceeds, confirming//.bazelrcstill parses after the comment removalNo behaviour change: a file that was never loaded cannot change behaviour by being deleted.
🤖 Generated with Claude Code