fix: Publish AAAA records so --type dns relays are really dual-stack - #41
Open
j4n wants to merge 1 commit into
Open
fix: Publish AAAA records so --type dns relays are really dual-stack#41j4n wants to merge 1 commit into
j4n wants to merge 1 commit into
Conversation
j4n
force-pushed
the
j4n/dualstack-dns
branch
3 times, most recently
from
August 6, 2026 11:23
0472cdb to
b57e7e1
Compare
j4n
force-pushed
the
j4n/docker-driver
branch
2 times, most recently
from
August 6, 2026 11:35
31246e2 to
97d7e54
Compare
j4n
force-pushed
the
j4n/dualstack-dns
branch
2 times, most recently
from
August 11, 2026 10:39
08fa0ed to
90ee135
Compare
hpk42
force-pushed
the
j4n/docker-driver
branch
from
August 11, 2026 12:36
904a895 to
faa68f4
Compare
hpk42
force-pushed
the
j4n/dualstack-dns
branch
from
August 11, 2026 12:36
90ee135 to
251ebd9
Compare
hpk42
force-pushed
the
j4n/docker-driver
branch
from
August 11, 2026 12:53
faa68f4 to
18a0dad
Compare
hpk42
force-pushed
the
j4n/dualstack-dns
branch
from
August 11, 2026 12:53
251ebd9 to
0c3ab70
Compare
j4n
force-pushed
the
j4n/dualstack-dns
branch
2 times, most recently
from
August 13, 2026 14:58
35e872d to
0f06b5f
Compare
Relays are dual-stack by default but DNS registrations published only an A record and the relay's zone generation never published an AAAA record and thus did not test dual-stack. Build the records once in address_records(), and settle ct.ipv6 beforehand; add a test for each case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relays are dual-stack by default but DNS registrations publish only an A record, so relay's zone generation never emitts an AAAA and thus does not test dual-stack. Change this to build the records once in address_records() and settle ct.ipv6 beforehand; add a test to assert single and dual stack case.