support underscore-prefixed domains for running core-tests, allowing for faster and independent python test runs - #7926
Merged
Merged
Conversation
link2xt
reviewed
Mar 1, 2026
link2xt
reviewed
Mar 2, 2026
hpk42
force-pushed
the
hpk/underdomains
branch
6 times, most recently
from
March 4, 2026 10:03
b0a66e5 to
cc74488
Compare
link2xt
force-pushed
the
link2xt/rustls-underscore
branch
2 times, most recently
from
March 4, 2026 17:56
d31f931 to
e40d4fd
Compare
link2xt
force-pushed
the
link2xt/rustls-underscore
branch
2 times, most recently
from
March 17, 2026 18:46
98068f5 to
965ba2e
Compare
link2xt
force-pushed
the
hpk/underdomains
branch
2 times, most recently
from
March 17, 2026 19:10
35231f1 to
2bee186
Compare
link2xt
force-pushed
the
link2xt/rustls-underscore
branch
2 times, most recently
from
March 17, 2026 19:14
c9b277f to
fe20db8
Compare
link2xt
force-pushed
the
hpk/underdomains
branch
from
March 17, 2026 19:14
2bee186 to
bd37b50
Compare
link2xt
force-pushed
the
hpk/underdomains
branch
from
March 17, 2026 19:28
bd37b50 to
cf5e15c
Compare
link2xt
force-pushed
the
link2xt/rustls-underscore
branch
from
March 17, 2026 19:28
fe20db8 to
1df7ec8
Compare
link2xt
force-pushed
the
hpk/underdomains
branch
from
March 19, 2026 01:52
cf5e15c to
92de732
Compare
hpk42
force-pushed
the
hpk/underdomains
branch
from
August 10, 2026 13:07
07277cc to
c893ed3
Compare
hpk42
force-pushed
the
hpk/underdomains
branch
3 times, most recently
from
August 12, 2026 23:16
a64b014 to
fa32fd5
Compare
link2xt
approved these changes
Aug 14, 2026
hpk42
force-pushed
the
hpk/underdomains
branch
from
August 14, 2026 09:09
fa32fd5 to
913f09d
Compare
hpk42
enabled auto-merge (rebase)
August 14, 2026 09:10
hpk42
force-pushed
the
hpk/underdomains
branch
from
August 14, 2026 09:12
913f09d to
c018263
Compare
link2xt
approved these changes
Aug 14, 2026
Relative paths only worked when running from `deltachat-rpc-client`.
Such relays serve self-signed certificates, and are created e.g. by cmlxc deploys.
Absolute form is meant for proxies and for example nginx rejects it with 400 if the host contains an underscore, breaking autoconfig discovery.
hpk42
force-pushed
the
hpk/underdomains
branch
from
August 14, 2026 09:57
c018263 to
307054f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow Delta Chat core tests against incus (cmlxc) containers running on underscore-prefixed domains (e.g. _alice.example.org). See https://github.com/chatmail/cmlxc/blob/main/README.md for how to install relay containers on linux machines.
speed local versus remote relay
All runs:
-n6, same rebased HEAD, identical tox invocation, identical test set.The iroh test module is skipped on both sides.
ci-chatmail.testrun.org_cm0.localchatdeltachat-rpc-client)python/tests)rpc gains less than CFFI because it is dominated by fixed waits that relay proximity cannot shorten:
test_get_all_accounts_deadlock13.9s,test_download_limit_chat_assignment~11-12s each,test_sleep5.0s.also contains a general fix for all rust HTTP requests
We were passing the absolute instead of origin form of the path/query part to our http requests, see fix commit.
(EDITED: old content removed since main already progressed to let core support underscore domains, so this is now about making core test suite work against _domains and especially local containers)