Skip to content

support underscore-prefixed domains for running core-tests, allowing for faster and independent python test runs - #7926

Merged
hpk42 merged 3 commits into
mainfrom
hpk/underdomains
Aug 14, 2026
Merged

support underscore-prefixed domains for running core-tests, allowing for faster and independent python test runs#7926
hpk42 merged 3 commits into
mainfrom
hpk/underdomains

Conversation

@hpk42

@hpk42 hpk42 commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

Allow Delta Chat core tests against incus (cmlxc) containers running on underscore-prefixed domains (e.g. _alice.example.org). See https://github.com/chatmail/cmlxc/blob/main/README.md for how to install relay containers on linux machines.

speed local versus remote relay

All runs: -n6, same rebased HEAD, identical tox invocation, identical test set.
The iroh test module is skipped on both sides.

Suite Remote ci-chatmail.testrun.org Local _cm0.localchat Speedup
rpc (deltachat-rpc-client) 68.7s 57.1s 1.20脳
CFFI (python/tests) 49.8s 18.9s 2.64脳

rpc gains less than CFFI because it is dominated by fixed waits that relay proximity cannot shorten: test_get_all_accounts_deadlock 13.9s, test_download_limit_chat_assignment ~11-12s each, test_sleep 5.0s.

also contains a general fix for all rust HTTP requests

We were passing the absolute instead of origin form of the path/query part to our http requests, see fix commit.

(EDITED: old content removed since main already progressed to let core support underscore domains, so this is now about making core test suite work against _domains and especially local containers)

Comment thread deltachat-rpc-client/tests/test_calls.py Outdated
Comment thread src/configure.rs Outdated
@hpk42
hpk42 force-pushed the hpk/underdomains branch 6 times, most recently from b0a66e5 to cc74488 Compare March 4, 2026 10:03
@link2xt
link2xt changed the base branch from main to link2xt/rustls-underscore March 4, 2026 17:44
@link2xt
link2xt force-pushed the link2xt/rustls-underscore branch 2 times, most recently from d31f931 to e40d4fd Compare March 4, 2026 17:56
@hpk42
hpk42 force-pushed the hpk/underdomains branch from cc74488 to 6592aa8 Compare March 7, 2026 08:50
@link2xt
link2xt force-pushed the link2xt/rustls-underscore branch 2 times, most recently from 98068f5 to 965ba2e Compare March 17, 2026 18:46
@link2xt
link2xt force-pushed the hpk/underdomains branch 2 times, most recently from 35231f1 to 2bee186 Compare March 17, 2026 19:10
@link2xt
link2xt force-pushed the link2xt/rustls-underscore branch 2 times, most recently from c9b277f to fe20db8 Compare March 17, 2026 19:14
@link2xt
link2xt force-pushed the link2xt/rustls-underscore branch from fe20db8 to 1df7ec8 Compare March 17, 2026 19:28
Base automatically changed from link2xt/rustls-underscore to main March 18, 2026 17:51
@hpk42
hpk42 force-pushed the hpk/underdomains branch from 92de732 to 41b3f75 Compare July 30, 2026 16:00
@hpk42
hpk42 force-pushed the hpk/underdomains branch from 41b3f75 to 7502617 Compare July 31, 2026 22:15
@hpk42 hpk42 changed the title feat: support underscore-prefixed domains with self-signed TLS certificates support underscore-prefixed domains for running core-tests Jul 31, 2026
@hpk42
hpk42 force-pushed the hpk/underdomains branch from 7502617 to 07277cc Compare August 2, 2026 22:48
@hpk42
hpk42 force-pushed the hpk/underdomains branch from 07277cc to c893ed3 Compare August 10, 2026 13:07
@hpk42
hpk42 force-pushed the hpk/underdomains branch 3 times, most recently from a64b014 to fa32fd5 Compare August 12, 2026 23:16
@hpk42 hpk42 changed the title support underscore-prefixed domains for running core-tests support underscore-prefixed domains for running core-tests, allowing for faster python test runs Aug 12, 2026
@hpk42 hpk42 changed the title support underscore-prefixed domains for running core-tests, allowing for faster python test runs support underscore-prefixed domains for running core-tests, allowing for faster and independent python test runs Aug 12, 2026
Comment thread deltachat-rpc-client/src/deltachat_rpc_client/pytestplugin.py Outdated
@hpk42
hpk42 force-pushed the hpk/underdomains branch from fa32fd5 to 913f09d Compare August 14, 2026 09:09
@hpk42
hpk42 enabled auto-merge (rebase) August 14, 2026 09:10
@hpk42
hpk42 force-pushed the hpk/underdomains branch from 913f09d to c018263 Compare August 14, 2026 09:12
hpk42 added 3 commits August 14, 2026 11:41
Relative paths only worked when running from `deltachat-rpc-client`.
Such relays serve self-signed certificates, and are created e.g. by cmlxc deploys.
Absolute form is meant for proxies and for example
nginx rejects it with 400 if the host contains an underscore, breaking autoconfig discovery.
@hpk42
hpk42 force-pushed the hpk/underdomains branch from c018263 to 307054f Compare August 14, 2026 09:57
@hpk42
hpk42 merged commit ce7c8db into main Aug 14, 2026
30 checks passed
@hpk42
hpk42 deleted the hpk/underdomains branch August 14, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants