CHEF-23720 - Replace CONTRIBUTING.md file with standard template for Workstation #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cgunasree08 <[email protected]>
cgunasree08
changed the title
clintoncwolfe
requested changes
Sep 3, 2025
Comment on lines
-18
to
-23
| Will Not Merge | ||
| -------------- | ||
| This section details, specifically, Pull Requests or features that will _not_ be merged: | ||
|
|
||
| 1. Matchers for non-Chef core resources. ChefSpec 3.0 introduced a way for cookbook maintainers to [package matchers _with_ their cookbooks](https://github.com/chefspec/chefspec#packaging-custom-matchers) at distribution time. | ||
| 2. New features without accompanying unit tests, cucumber tests, and documentation. |
There was a problem hiding this comment.
Move this section into the README on this PR
Comment on lines
-36
to
-40
| Testing | ||
| ------- | ||
| Whether your pull request is a bug fix or introduces new classes or methods to the project, we kindly ask that you include tests for your changes. Even if it's just a small improvement, a test is necessary to ensure the bug is never re-introduced. | ||
|
|
||
| We understand that not all users submitting pull requests will be proficient with RSpec. The maintainers and community as a whole are a helpful group and can help you with writing tests. The [Better Specs](http://betterspecs.org/) site should provide some helpful resources to get you started. |
There was a problem hiding this comment.
Move this to README. Travis is no longer used.
…EADME.md Signed-off-by: cgunasree08 <[email protected]>
cgunasree08
force-pushed
the
cg/redirect_contributors_active
branch
from
1b20ce0 to
3ce104f
Compare
clintoncwolfe
requested changes
Sep 4, 2025
README.md
Outdated
| MIT - see the accompanying [LICENSE](https://github.com/chefspec/chefspec/blob/main/LICENSE) file for details. | ||
|
|
||
|
|
||
| ## Will Not Merge |
There was a problem hiding this comment.
Retitle section to be "Changes that will not be accepted"
Signed-off-by: cgunasree08 <[email protected]>
Signed-off-by: cgunasree08 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace CONTRIBUTING.md file with standard template for Workstation
This pull request replaces the existing CONTRIBUTING.md file with the standard template for the Workstation project. As part of the repo standardization effort we are replacing all the different contributing guides with a standard template that links to a published version of the chef-oss-practices repo.
This PR is intended to be a mere mechanical change, not a change in policy. Watch chef/chef-oss-practices for changes in policy.
The link provided in the template may not function at the time this PR is opened, in which case this PR is intended to remain in Draft status if the repo permits; in any case it should not be merged until the link is live.