Fix release image workflow dispatch - #415
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesRelease workflow dispatch
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes a reliability issue in the production release workflow by ensuring the gh workflow run dispatch for the Postgres+EQL image build works even when the job runs without a repository checkout (no local .git directory).
Changes:
- Update the production image-build dispatch to pass
--repo "${GITHUB_REPOSITORY}"explicitly togh workflow run. - Add inline comments documenting why
--repois required for this no-checkout job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
freshtonic
left a comment
There was a problem hiding this comment.
Correct fix. The dispatch-postgres-image job runs with no checkout, so gh workflow run had no .git to infer the repository from; passing --repo ${GITHUB_REPOSITORY} explicitly resolves that, and the added comment documents why the checkout is deliberately absent. --ref/-f inputs unchanged. CI-only, so no changeset needed. LGTM.
Summary
Fix the production release workflow's Postgres+EQL image dispatch when the job runs without a repository checkout.
gh workflow runotherwise tries to infer the repository from the current directory and fails with:Passing
--repo "$GITHUB_REPOSITORY"makes the dispatch independent of local Git metadata, matching the existing prerelease Rust dispatch pattern.Verification
release.ymlparses as YAML.Summary by CodeRabbit