Conversation
…winston, and improve local logging
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
- Refactor _detectVersion to robustly parse version using regex and handle missing versions - Catch and log version detection errors - Log detected SCANCODE and aggregated handler versions on initialization Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
- Enhance error and version logging in fsfeReuse and licensee processors - Improve error reporting for LICENSES directory access and REUSE execution - Add attachment path support in file store for keys - Minor formatting cleanup Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
…hment paths Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
|
|
||
| # REUSE | ||
| RUN pip3 install setuptools | ||
| RUN pip3 install reuse==3.0.1 |
There was a problem hiding this comment.
Whenever you update the PR, consider bumping this version as well. REUSE 6.x has quite interesting performance gains and also fixes potential license/copyright detection issues.
|
I compared this PR against current master to figure out what's still worth merging. Short version: about half of it landed through other work, but there are real gaps remaining. What's already done separately: Node 24 is in CI and both Dockerfiles. The winston 3 migration in What's still broken on master that this PR fixes:
Smaller stuff: .gitignore is missing a Honestly, given how much master has diverged, rebasing this into one coherent PR would be painful. It'd probably be easier to cherry-pick the remaining fixes into a few focused PRs: one for the Dockerfile fixes (REUSE bump, ENV syntax, DevDockerfile bug), one for the logging improvements, and maybe one for proxy support. |
|
Hi @JamieMagee , Sorry, I was really busy with other things at work! I finally got some time to look deeper into clearly defined again and I'll look into it tomorrow! |
Overview
This PR introduces several significant updates and improvements to the project, including:
Node.js version upgrades (Dockerfiles, CI, engines)
Dependency updates (major and minor, including security and compatibility)
Changes
Node.js Version Upgrades
Dependency Updates
cdConfig.js: IntroducedbaseFileLocationfor consistent file path handling;cd_filenow has separatelocationandattachmentLocationpropertiesfile.js: Attachments are now stored in a dedicated attachment directory ifattachmentLocationis set; File naming for attachments improved (attachment:KEY → attachmentLocation/KEY.json)winston-azure-application-insightsintegration.winstonand refined local logging.Miscellaneous
env.jsonto.gitignoreto prevent local config leakage.