Skip to content

fix(ui): add accessible name to API Keys search input#9051

Closed
maxyinger wants to merge 2 commits into
mainfrom
max/fix-api-keys-search-aria-label
Closed

fix(ui): add accessible name to API Keys search input#9051
maxyinger wants to merge 2 commits into
mainfrom
max/fix-api-keys-search-aria-label

Conversation

@maxyinger

@maxyinger maxyinger commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Description

  • Adds label to user-profile -> api-keys search
  • suppresses chrome specific warning by adding a name attr
  • turns off autocomplete. didn't feel needed/intentional for this instance. happy to turn it back on if wanted.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes
    • Improved accessibility for the API Keys search field by adding a screen-reader-friendly label, ensuring it’s announced correctly.
    • Disabled browser autocomplete for the API Keys search input.
  • Tests
    • Added coverage to verify the search input is rendered with the expected accessible name.

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jun 30, 2026 9:27pm
swingset Ready Ready Preview, Comment Jun 30, 2026 9:27pm

Request Review

@changeset-bot

changeset-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 650911e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds an aria-label to the API Keys search input, verifies the accessible name in a test, and records the patch release in a changeset.

Changes

API Keys Search Accessibility

Layer / File(s) Summary
Search input accessibility
packages/ui/src/components/APIKeys/APIKeys.tsx
Adds an aria-label from the existing search localization string and sets autoComplete='off' on the API Keys search input.
Accessible name test
packages/ui/src/components/APIKeys/__tests__/APIKeys.spec.tsx
Adds a test that renders APIKeys and asserts the searchbox is exposed with the expected accessible name.
Changeset entry
.changeset/dirty-rockets-read.md
Adds a patch changeset for @clerk/ui describing the accessibility update.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny found a search box small,
Gave it a name so screens can call.
🐇 With tests that hop and labels bright,
The API Keys feel just right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: adding an accessible name to the API Keys search input.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-30T21:28:53.020Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 650911e.

@pkg-pr-new

pkg-pr-new Bot commented Jun 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9051

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9051

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9051

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9051

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9051

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9051

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9051

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9051

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9051

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9051

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9051

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9051

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9051

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9051

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9051

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9051

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9051

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9051

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9051

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9051

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9051

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9051

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9051

commit: 650911e

Comment thread packages/ui/src/components/APIKeys/APIKeys.tsx

@wobsoriano wobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@maxyinger

Copy link
Copy Markdown
Contributor Author

Don't have merge access on this repo yet if either of you don't mind hooking me up
Screenshot 2026-06-30 at 4 14 07 PM

@wobsoriano wobsoriano enabled auto-merge (squash) June 30, 2026 22:17
@wobsoriano wobsoriano closed this Jun 30, 2026
auto-merge was automatically disabled June 30, 2026 23:14

Pull request was closed

@wobsoriano

wobsoriano commented Jun 30, 2026

Copy link
Copy Markdown
Member

@maxyinger there's a weird issue so I had to close (but failed to reopen), do you have access to reopen?

@wobsoriano

Copy link
Copy Markdown
Member

#9055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants