feat(joint-react): cell focus/blur events, reactive grid, collection setters#3427
Open
samuelgja wants to merge 1 commit into
Open
feat(joint-react): cell focus/blur events, reactive grid, collection setters#3427samuelgja wants to merge 1 commit into
samuelgja wants to merge 1 commit into
Conversation
…ement with JointJS collections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several
@joint/react<Paper>/ graph-API fixes and additions reportedonCellFocus/onCellBlurevents —<Paper>now emitscell:focus/cell:blurwhen a focusable node (e.g. atabindexelement) inside a cell gains/loses focus. Available both as<Paper>props and viauseOnPaperEvents. Implemented by delegating the bubblingfocusin/focusoutDOM events to.joint-cell(plainfocus/blurdo not bubble — the same reason React's ownonFocus/onBlurusefocusin/focusout).Reactive visual grid — changing
drawGridSize(and grid options set via theoptionsescape hatch) now redraws the grid. Previously onlydrawGrid/gridSizetriggered a redraw, sodrawGridSizeupdated snapping but left the rendered grid stale.removeCells()/resetCells()accept a collection — a JointJS cell collection (e.g. a selection'scollection) can be passed directly, without.toArray(). AddsCellCollection/CellRefListtypes.<Paper>stylevsclassName— verified inlinestylecorrectly wins overclassName, same as a plain HTMLdiv. It already behaved correctly; added a regression test to lock it in.Motivation and Context
Fixes:
All checks pass locally: typecheck, lint, knip, and Jest (React 19 — 1032 tests, React 18 — 1028 tests). New/updated unit tests cover each change.