Skip to content

test: add context manager tests for __enter__ behavior#274

Merged
cnuernber merged 1 commit intoclj-python:masterfrom
lidorcg:master
Jan 19, 2026
Merged

test: add context manager tests for __enter__ behavior#274
cnuernber merged 1 commit intoclj-python:masterfrom
lidorcg:master

Conversation

@lidorcg
Copy link
Contributor

@lidorcg lidorcg commented Nov 11, 2025

fix: update 'with' macro to bind return value of __enter__ correctly

#273

fix: update 'with' macro to bind return value of __enter__ correctly
@jjtolton
Copy link
Contributor

Good catch. Technically this is a backwards breaking change but I sincerely doubt anyone is explicitly expecting the bound/return value to always be nil and taking conditional logic from that.

Traveling right now for conference stuff but I will pull it and check it when I can.

Thanks for the contribution!

@jjtolton
Copy link
Contributor

jjtolton commented Nov 30, 2025

@lidorcg overall looks good to me. Tested locally and working great. Would prefer you revert the unrelated formatting changes and do that in separate PR. Excellent contribution, thank you!

@cnuernber cnuernber merged commit 51ea589 into clj-python:master Jan 19, 2026
9 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants