Fix the upgrade version tool #4085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
force-pushed
the
jdetter/upgrade-version-upgrade-tool
branch
from
f1ad0d0 to
5a85922
Compare
…tool' into jdetter/upgrade-version-upgrade-tool
bfops
reviewed
Jan 26, 2026
bfops
reviewed
Jan 26, 2026
bfops
reviewed
Jan 26, 2026
bfops
reviewed
Jan 26, 2026
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
This looks good to me, but I have some questions
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
Centril
pushed a commit
that referenced
this pull request
Jan 27, 2026
# Description of Changes <!-- Please describe your change, mention any related tickets, and so on here. --> This fixes 2 issues with the upgrade version tool: 1. The typescript bindings need to be updated otherwise the typescript test in CI will fail 2. The snapshots need to be updated When the version upgrade tool check in CI runs, snapshot changes are accepted automatically via the `--accept-snapshots` cli argument. When you are running this tool locally without `--accept-snapshots` you will be asked to manually review the snapshot changes before doing a final test to make sure the snapshots are correct. # API and ABI breaking changes <!-- If this is an API or ABI breaking change, please apply the corresponding GitHub label. --> None # Expected complexity level and risk 1 - this just updates the version upgrade tool <!-- How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change. This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code. If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways. --> # Testing <!-- Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected! --> - [x] Version bump 1.12.0 worked: #4084 - [x] CI passes --------- Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This fixes 2 issues with the upgrade version tool:
When the version upgrade tool check in CI runs, snapshot changes are accepted automatically via the
--accept-snapshotscli argument. When you are running this tool locally without--accept-snapshotsyou will be asked to manually review the snapshot changes before doing a final test to make sure the snapshots are correct.API and ABI breaking changes
None
Expected complexity level and risk
1 - this just updates the version upgrade tool
Testing