Skip to content

Fix some warnings in C# #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clockwork-labs-bot merged 2 commits into from
May 5, 2026
Merged

Fix some warnings in C# #4956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b1c077
[bfops/argument-null-exception]: Fix ArgumentNullException
bfops May 5, 2026
a46ce8d
[bfops/argument-null-exception]: format
bfops May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/bindings-csharp/BSATN.Runtime/Builtins.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
namespace SpacetimeDB;

using System.Diagnostics;
using System.Runtime.InteropServices;
using SpacetimeDB.BSATN;
#if !NET5_0_OR_GREATER
using System.Diagnostics;
#endif

internal static class Util
{
Expand Down
4 changes: 4 additions & 0 deletions crates/bindings-csharp/BSATN.Runtime/QueryBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,10 +877,14 @@ public static string FormatStringLiteral(ReadOnlySpan<char> value) =>

public static string FormatHexLiteral(string hex)
{
#if NET6_0_OR_GREATER
ArgumentNullException.ThrowIfNull(hex);
#else
if (hex is null)
{
throw new ArgumentNullException(nameof(hex));
}
#endif

var s = hex;
if (s.StartsWith("0x", StringComparison.OrdinalIgnoreCase))
Expand Down
Loading