Submodules (TS) - #5823
Open
bradleyshep wants to merge 41 commits into
Open
Conversation
bradleyshep
requested review from
JulienLavocat,
aasoni,
clockwork-tien and
cloutiertyler
August 26, 2026 16:35
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bradleyshep
marked this pull request as ready for review
August 26, 2026 17:53
cloutiertyler
left a comment
cloutiertyler
left a comment
Contributor
There was a problem hiding this comment.
I think we need to break this into multiple PRs:
- A PR with just the high priority submodules that do not depend on
fetch/async procs, and whose API we've carefully designed (e.g. cron, resend, agents ?) - High priority ones that depend on
fetch/async procs - Low priority/nice to have ones ones (e.g. grid, lobby, api-keys)
Ale and I would like to make sure the APIs for all of these submodules are carefully designed because we're going to have to maintain them indefinitely. And with 1035 files in this PR it's a little too overwhelming to review.
Contributor
|
We also want to make sure we use the correct conventions for typescript variable naming. I saw at least in one README an example code that used snake case for variable names. We should make sure both the code and the README examples have variable names consistent with the typescript conventions. Usually:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds reusable TypeScript submodules for SpacetimeDB, including:
Each submodule includes package metadata, documentation, tests, and an example where applicable. The change also adds shared example UI code and connects the packages to the existing pnpm workspace, lint configuration, and CI workflow.
Example screenshots
Agents
API Keys
Auth
Cron
Files
Grid
Lobby
PostHog
Presence
Rate Limit
Resend
Stripe
API and ABI breaking changes
No existing API or ABI is changed. This PR adds new TypeScript package APIs.
Expected complexity level and risk
3/5
The change is large, but most code is isolated in new top-level submodule folders. The main risk is in scheduled work, native HTTP routes, and external provider integrations such as Stripe, Resend, and PostHog.
Testing
Rollback safety impact
n/a