Skip to content

Fix screenshot endpoint example to use URL instead of HTML#27784

Merged
kathayl merged 1 commit intoproductionfrom
fix-screenshot-url-example
Jan 23, 2026
Merged

Fix screenshot endpoint example to use URL instead of HTML#27784
kathayl merged 1 commit intoproductionfrom
fix-screenshot-url-example

Conversation

@kathayl
Copy link
Contributor

@kathayl kathayl commented Jan 21, 2026

Description

The example-screenshot-from-url.mdx partial file was incorrectly using the html parameter instead of the url parameter since its creation on September 15, 2025.

This PR fixes the example under the "Take a screenshot from a URL" section to properly demonstrate taking a screenshot from a URL.

Changes

  • Changed the example in src/content/partials/browser-rendering/example-screenshot-from-url.mdx from using html: 'Hello World!' to url: 'https://workers.cloudflare.com/product/browser-rendering/'
  • Removed the screenshotOptions parameter to keep the example simple and focused on the URL usage

Investigation

Checked git history and confirmed this was wrong from the start - the file was never correct.

@kathayl kathayl requested a review from a team as a code owner January 21, 2026 16:42
@github-actions
Copy link
Contributor

This PR requires additional review attention because it affects the following areas:

Partials

This PR updates partial files, which are pieces of content used across multiple files in our Render component.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
* @cloudflare/pcx-technical-writing

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

@ToriLindsay ToriLindsay self-assigned this Jan 22, 2026
@kathayl kathayl enabled auto-merge (squash) January 22, 2026 15:07
@kathayl kathayl disabled auto-merge January 22, 2026 18:17
@kathayl kathayl requested review from celso and mchenco as code owners January 22, 2026 18:21
The example-screenshot-from-url.mdx partial was incorrectly using the 'html' parameter instead of 'url' parameter since its creation. This fixes the example to properly demonstrate taking a screenshot from a URL as the section title indicates.
@kathayl kathayl force-pushed the fix-screenshot-url-example branch from 8b9959b to 22a1300 Compare January 23, 2026 21:12
@kathayl kathayl enabled auto-merge (squash) January 23, 2026 21:13
@kathayl kathayl merged commit 024df4c into production Jan 23, 2026
9 checks passed
@kathayl kathayl deleted the fix-screenshot-url-example branch January 23, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants