Skip to content

chore: remove CI-enforced checks from Flue style review#31287

Merged
mvvmm merged 13 commits into
productionfrom
agents/clarify-angle-bracket-rule
Jun 9, 2026
Merged

chore: remove CI-enforced checks from Flue style review#31287
mvvmm merged 13 commits into
productionfrom
agents/clarify-angle-bracket-rule

Conversation

@mvvmm

@mvvmm mvvmm commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes Flue style-guide review rules that duplicate issues already caught by failing CI/build steps. This keeps agent review focused on style and conventions that CI does not reliably enforce.

Removed checks include MDX syntax parse failures, missing component imports or import placement failures, invalid DashButton routes, schema/build-validated required component props, and schema-validated frontmatter fields such as required title and numeric sidebar.order.

Kept checks include style-only link wording/path conventions, image parent-directory guidance, pcx_content_type/description expectations not currently schema-enforced, and component usage preferences such as TypeScriptExample, PackageManagers, and DashButton for dashboard navigation.

Also adds .flue/AGENTS.md with the policy for future review rules: do not add agent findings for issues already reliably caught by CI.

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
* @cloudflare/product-owners
*.ts @cloudflare/content-engineering, @kodster28

@mvvmm mvvmm marked this pull request as ready for review June 7, 2026 15:51
@mvvmm mvvmm requested a review from a team as a code owner June 7, 2026 15:51
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review

⏸️ Automatic reviews for this PR are paused.

This PR has already received 2 automatic reviews. To run another review, a codeowner can comment /review or /full-review.

Tip: Keep PRs in draft mode until they are ready for review — the bot skips draft PRs automatically.


✅ No style-guide issues found in commit 1ee10c7.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.

@ask-bonk ask-bonk Bot added documentation Documentation edits content:edit Request for content edits labels Jun 7, 2026
Comment thread .agents/references/style-guide.md
@ask-bonk

ask-bonk Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

One minor suggestion posted.

  • LOW.agents/references/style-guide.md line 19: the <zone> placeholder example should be <ZONE_ID> to match the repository convention for variable placeholders (ALL_CAPS_UNDERSCORES).

@ask-bonk

ask-bonk Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

PR #31287 reviewed.

Labels applied: documentation, content:edit

Summary:
The PR is a focused clarification to the agent style guide reference that correctly scopes the angle bracket escaping rule to literal characters in prose/tables/headings and exempts valid JSX component tags. Good change.

One issue found:

  • LOW.agents/references/style-guide.md line 19: the <zone> placeholder example should be <ZONE_ID> to match the repository's own ALL_CAPS_UNDERSCORES convention for variable placeholders documented later in the same file.

An inline suggestion has been posted on the PR to address this.

github run

@mvvmm

mvvmm commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

/bonk review

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The table format clearly scopes the escaping rule to literal characters and correctly exempts valid JSX syntax.

@ask-bonk

ask-bonk Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review posted on PR #31287.

I reviewed the current diff (commit 898c7bc) and found no issues. The table format is clean, the scope clarification is accurate, and the file passes Prettier formatting. The prior feedback about the <zone> placeholder example was already addressed by the author when they converted the blockquote into a table column in commit 2/3.

github run

@mvvmm mvvmm changed the title chore: clarify angle bracket escaping rule scope in agent style guide reference chore: clarify agent review rule scope Jun 7, 2026
@mvvmm mvvmm changed the title chore: clarify agent review rule scope chore: remove CI-enforced checks from agent references Jun 7, 2026
@mvvmm mvvmm changed the title chore: remove CI-enforced checks from agent references chore: remove CI-caught checks from Flue style review Jun 7, 2026
@mvvmm mvvmm changed the title chore: remove CI-caught checks from Flue style review chore: remove CI-enforced checks from Flue style review Jun 7, 2026
@mvvmm

mvvmm commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

@mvvmm mvvmm requested review from a team and kodster28 as code owners June 8, 2026 15:32
@mvvmm mvvmm merged commit 2499e20 into production Jun 9, 2026
16 checks passed
@mvvmm mvvmm deleted the agents/clarify-angle-bracket-rule branch June 9, 2026 01:55

@hacyberglobal hacyberglobal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content:edit Request for content edits documentation Documentation edits size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants