computer: Add workspace file tools - #81
Open
aron-cf wants to merge 4 commits into
Open
Conversation
馃 Changeset detectedLatest commit: 8166cb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your interest in Cloudflare Computer. This repository does not accept unsolicited pull requests. Please use one of the accepted contribution paths instead:
If a maintainer asked you to open this pull request, they can add the |
commit: |
aron-cf
marked this pull request as ready for review
August 7, 2026 15:21
Share a store-scoped, normalized-path lock between edit and write so read-modify-write cycles cannot clobber concurrent writes or block unrelated workspaces.
Expose the missing workspace tools, keep find and grep available in read-only mode, bound their result pages, and serialize delete with other mutations.
Allow any non-negative grep offset so continuation values emitted after large result sets remain valid inputs to the next tool call.
Record the new search and deletion tools and shared mutation locking with the Computer package that exposes them.
aron-cf
force-pushed
the
stack/improve-tools-03-file-tools
branch
from
August 7, 2026 15:29
88b9b07 to
8166cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 3 of 7. Base:
stack/improve-tools-02-computer-fs-plumbing. Head:stack/improve-tools-03-file-tools.The Computer tool set lacked recursive path search, text search, and deletion. Writes could also race an edit between its read and write phases, losing one caller's update.
This change adds
find,grep, anddeletetocreateAITools. Search remains available in read-only mode, while deletion follows the existing read-only policy for mutations.edit,write, anddeletenow share a store-scoped lock keyed by normalized path. Search responses are bounded and return offsets that remain valid for result sets of any size.Verification
npm run typecheck --workspace @cloudflare/computer npm test --workspace @cloudflare/computer -- src/tools/ai.test.tsThe next stack part improves
readoutput and adds model-facing image and PDF content.