This repository was archived by the owner on Apr 8, 2021. It is now read-only.
Fix: Typescript Type Definition for Configuration.Options.secure_distribution type#27
Open
seibert-io wants to merge 2 commits intocloudinary:masterfrom
Open
Fix: Typescript Type Definition for Configuration.Options.secure_distribution type#27seibert-io wants to merge 2 commits intocloudinary:masterfrom
seibert-io wants to merge 2 commits intocloudinary:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Type definition for
Configuration.Options.secure_distributionis wrong. Type definitions declare it asboolean | undefinedpkg-cloudinary-core/cloudinary-core.d.ts
Line 813 in 47ffb3b
See
pkg-cloudinary-core/cloudinary-core.js
Line 4815 in 47ffb3b
pkg-cloudinary-core/cloudinary-core.js
Line 4857 in 47ffb3b