router: initial implementation + clean up - #126
Draft
mweibel wants to merge 5 commits into
Draft
Conversation
Correct the `loaad_balancer_listener` typo that excluded the load_balancer_listener module from the cloudscale action group, and add the missing volume_snapshot module.
Guard against a null resource list returned by the API, and correct a typo in the "resource not found" error message. This occured when trying to run the integration tests against a resource not yet in the prod API.
Replace hardcoded https://api.cloudscale.ch/v1 URLs across the integration suite with a cloudscale_api_url override that defaults to production. Add an api_url module_defaults block per target and an integration_config.yml.template documenting the override so the suite can run against a staging API.
Add the cloudscale_ch.cloud.router and cloudscale_ch.cloud.interface modules with integration test targets, register them in the cloudscale action group, and add a router cleanup task. The new targets use the configurable cloudscale_api_url so they can run against a staging API.
Add a contributor guide for setting up the collection layout, running sanity/integration tests, overriding the integration test API URL, and building the module documentation locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The individual commits should be reviewable and have appropriate commit messages. Best would be to not squash merge this to keep the history.
Question to the reviewer: Should I already update the
changelog.yamlfile with 2.6.0 changelog or will we do this later in case anything else comes in between?