improve Go setup - #91
Merged
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mweibel
commented
Aug 3, 2026
mweibel
marked this pull request as ready for review
August 3, 2026 13:51
zizmor complained about this but in the SDKs case its really not applicable because we dont actually release anything. It still doesnt really hurt so its ok to add
mweibel
force-pushed
the
improve-go-setup
branch
from
August 5, 2026 13:52
4ac8c67 to
d4c397a
Compare
alakae
reviewed
Aug 7, 2026
|
|
||
| client := &MetadataClient{ | ||
| client: &http.Client{Timeout: defaultTimeout}, | ||
| client: httpClient, |
Contributor
There was a problem hiding this comment.
Suggestion for the changelog:
Fixed: NewMetadataClient(httpClient) was silently ignoring the passed-in *http.Client and always using a default one.
removes automated release again based on discussion.
mweibel
force-pushed
the
improve-go-setup
branch
from
August 7, 2026 08:43
a872d9b to
acfa6af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placeholder PR, will add more improvements later.