[AIAA] Add assessment workflow labels and repair label sync in settings.yml - #367
Merged
Merged
Conversation
…ncf#365) Assisted-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io>
✅ Deploy Preview for cncf-techdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Repairs declarative label synchronization and adds the assessment workflow labels required by the specification.
Changes:
- Quotes all label colors to preserve six-character hex strings.
- Reconciles configured labels with the live repository.
- Adds nine assessment lifecycle labels.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
I'm going to merge this as is (bypassing reqs), so i have time to troubleshoot this afternoon if it doesn't solve the automated label update issues this repo is having. |
github-project-automation
Bot
moved this to Todo
in AI-assisted TechDocs Assessment Build
github-project-automation
Bot
moved this from Todo
to Done
in AI-assisted TechDocs Assessment Build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the nine assessment workflow labels (spec sections 12–13) and fixes
why
.github/settings.ymlhas never synced. Spec section 16, step 1.Tracking: #365. Spec PR: #363. Bound by P-1 and HC-4. Only the
labels:block changed.Root cause
Unquoted colors aren't strings to YAML:
#-prefixed become comments(null), all-digit become integers (008672 → 8672), and
89E295becomesthe float 8.9e+296. That last one is the 2022 commit that never applied,
so every sync failure since shares this cause. Every color is now
quoted.
Reconciliation (live wins)
A repaired file likely triggers the first real sync on merge, and
declarative sync deletes live labels missing from the file. So the block
now matches live (snapshot 2026-08-14) before adding anything:
admin: duplicates collapsed; live color; file description kept(deliberate addition).
meta: removed (in file, not live).suggested doc: 89E295 → d93f0b (the 2022 change never applied).broken-link,techdocs-upstream: added (live, missing from file).New labels
needs-triage,triage/accepted,triage/declined,phase/assessment,phase/implementation,phase/backlog,verified,confirmed,skip-implementation.Names come from the spec; colors and descriptions are review points.
Verification
nine new labels; all colors string-typed six-hex. 36 pass.
npm run checkpasses.fallback is by-hand
gh label create; either path recorded on [AIAA] Build step 1: workflow labels in .github/settings.yml #365.