Conversation
|
@DavertMik what do you think if running all checks in parallel using Promise.all? |
lib/command/check.js
Outdated
| if (!Object.values(checks).every(check => check === true)) { | ||
| output.error("Something went wrong. Checks didn't pass.") | ||
| output.print() | ||
| getMachineInfo() |
There was a problem hiding this comment.
missing await here I think.
| "fn-args": "4.0.0", | ||
| "fs-extra": "11.2.0", | ||
| "glob": "^11.0.0", | ||
| "fuse.js": "^7.0.0", |
There was a problem hiding this comment.
got error if this lib removed
There was a problem hiding this comment.
ouch, this is bad merge, right
|
@kobenguyent good point for using Promise.all |
|
@kobenguyent btw, it's only 1s on our workflow https://github.com/codeceptjs/CodeceptJS/actions/runs/12682764702/job/35348708849?pr=4727 |
|
@DavertMik I have two more things:
|
|
@DavertMik one more thing:
|
| checks['config'] = err | ||
| } | ||
|
|
||
| printCheck('config', checks['config'], config.name) |
There was a problem hiding this comment.
how about config name here?
yes, I added it as
For For But anyway, I think |

Created
checkcommand to quickly test config, tests, and that browser can be started and finishedThis can be done locally or on CI before running tests