Skip to content

fix(graphql): restore directChangedFiles field on Comparison type #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

fix(graphql): restore directChangedFiles field on Comparison type #1981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/codecov-api/graphql_api/types/comparison/comparison.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ type Comparison {
impactedFilesCount: Int!
indirectChangedFilesCount: Int!
patchTotals: CoverageTotals
directChangedFiles(filters: ImpactedFilesFilters): ImpactedFilesResult!
directChangedFilesCount: Int!
baseTotals: CoverageTotals
headTotals: CoverageTotals
Expand Down
17 changes: 17 additions & 0 deletions apps/codecov-api/graphql_api/types/comparison/comparison.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,23 @@ def resolve_impacted_files_count(
return len(comparison.impacted_files)


@comparison_bindable.field("directChangedFiles")
@sync_to_async
def resolve_direct_changed_files(
comparison_report: ComparisonReport, info: GraphQLResolveInfo, filters=None
):
command: CompareCommands = info.context["executor"].get_command("compare")
comparison: Comparison = info.context.get("comparison", None)

# Force filter to direct changes only (hasUnintendedChanges=False)
filters = dict(filters) if filters else {}
filters["has_unintended_changes"] = False

return {
"results": command.fetch_impacted_files(comparison_report, comparison, filters)
}


@comparison_bindable.field("directChangedFilesCount")
@sync_to_async
def resolve_direct_changed_files_count(
Expand Down
Loading