fix(graphql): add deprecated orderingDirection to ImpactedFilesFilters for backward compatibility - #1982
fix(graphql): add deprecated orderingDirection to ImpactedFilesFilters for backward compatibility#1982sentry[bot] wants to merge 1 commit into
Conversation
…s for backward compatibility
|
🤖 Harness AI Code Review in progress… · View results → |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (80.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1982 +/- ##
==========================================
- Coverage 91.61% 91.61% -0.01%
==========================================
Files 1336 1336
Lines 53174 53177 +3
Branches 1647 1647
==========================================
+ Hits 48715 48717 +2
- Misses 4138 4139 +1
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This PR addresses a
GraphQLErrorwhere older clients were querying theimpactedFilesfield withfilters: {orderingDirection: NAME}. TheImpactedFilesFiltersinput type was refactored to use a nestedordering: { direction, parameter }structure, causing these queries to fail.To maintain backward compatibility for existing clients, this change introduces the following:
orderingDirection: OrderingDirectionas a deprecated field to theImpactedFilesFiltersinput type inapps/codecov-api/graphql_api/types/inputs/impacted_files_filters.graphql. This allows the GraphQL engine to accept the old field without error._apply_filtersmethod inapps/codecov-api/compare/commands/compare/interactors/fetch_impacted_files.pyto check fororderingDirectionif the nestedordering.directionis not provided. WhenorderingDirectionis used, theparameteris defaulted toFILE_NAMEto match the expected behavior of the old query.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-EVZ