Stage v6.0.0

[ct-anjali-patel]

Commit Checklist

• Remove UNUSED comment code
• Remove any logging like console.log
• Remove all warnings and errors while build
• Check vulnerabilities
• Make sure build for production is working. Try running command for prod build in local.
• Fix prettier: npx prettier --write .
• Fix eslint: npx eslint src\ --fix command
• Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM
• WCAG

General

• Follow import structure. module/third-party/files/component/style/types/asset
• Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow)
• Before adding custom style follow our pre-built components/elements

[phoenixcoded20]

{
"file": ".yarn/install-state.gz",
"approved": true
}

[phoenixcoded20]

{
"file": "angular.json",
"approved": false,
"issues": [
{
"type": "best-practice",
"severity": "low",
"description": "There is no newline at the end of the file, which is not a common practice and can lead to issues with some tools or editors.",
"recommendedFix": "Add a newline character at the end of the file.",
"codeFix": "\n"
}
]
}

[phoenixcoded20]

{
"file": "src/app/app-config.ts",
"approved": false,
"issues": [
{
"type": "best-practice",
"severity": "medium",
"description": "Class names should be in PascalCase for consistency with React component naming conventions.",
"recommendedFix": "Consider renaming the class to follow PascalCase convention.",
"codeFix": "export class BerryDefaultConfig {\n static isCollapse_menu = false;\n static font_family = 'Roboto'; // Roboto, poppins, inter\n}"
}
]
}

[phoenixcoded20]

{
"file": "src/app/app-routing.module.ts",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "The routing configuration's variable name was changed from 'routes' to 'appRoutes' without updating its usage in the 'RouterModule.forRoot()' method, which can lead to runtime errors since 'routes' is no longer defined.",
"recommendedFix": "Ensure that the correct variable is used in the RouterModule.forRoot method to avoid reference errors.",
"codeFix": "- imports: [RouterModule.forRoot(routes)],\n+ imports: [RouterModule.forRoot(appRoutes)],"
}
]
}

[phoenixcoded20]

{
"file": "src/app/app.component.ts",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "The changed property 'styleUrl' is incorrect. The correct property should be 'styleUrls' (plural). This will prevent styles from being applied correctly.",
"recommendedFix": "Revert 'styleUrl' back to 'styleUrls'.",
"codeFix": "- styleUrl: './app.component.scss',\n+ styleUrls: ['./app.component.scss'],"
}
]
}

[phoenixcoded20]

{
"file": "src/app/demo/dashboard/default/default.component.html",
"approved": false,

"issues": [
{
"type": "best-practice",
"severity": "medium",
"description": "Using 'javascript:' as the href for a link is a deprecated practice and can lead to undesirable effects. Instead, 'javascript:void(0)' should be used to prevent any default action.",
"recommendedFix": "Change the href from 'javascript:' to 'javascript:void(0)' for better practice.",
"codeFix": "<a href="javascript:void(0)" class="b-b-primary text-primary f-w-500">\n View all\n <i class="ti ti-chevron-right">\n "
},
{
"type": "best-practice",
"severity": "medium",
"description": "The use of 'ngbDropdown', 'ngbDropdownToggle', and 'ngbDropdownMenu' attributes indicate the use of an Angular component, which may not be compatible with React's paradigm. It is important to ensure this is suitable or refactor appropriately.",
"recommendedFix": "Replace Angular's dropdown functionality with a React-compatible dropdown implementation.",
"codeFix": ""
},
{
"type": "nit",
"severity": "low",
"description": "The absence of a newline at the end of the file can cause issues with some version control systems and code editors.",
"recommendedFix": "Add a newline at the end of the file.",
"codeFix": "\n"
}
]
}

[phoenixcoded20]

{
"file": "src/app/demo/dashboard/default/default.component.ts",
"approved": false,

"issues": [
{
"type": "best-practice",
"severity": "medium",
"description": "The styleUrls property is incorrectly named as styleUrl. It should be styleUrls to be recognized properly by Angular.",
"recommendedFix": "Correct the property name from styleUrl to styleUrls.",
"codeFix": "@component({\n selector: 'app-default',\n imports: [...SHARED_IMPORTS, BajajChartComponent, BarChartComponent, ChartDataMonthComponent],\n templateUrl: './default.component.html',\n styleUrls: ['./default.component.scss']\n})"
}
]
}

[phoenixcoded20]

{
"file": "src/app/demo/elements/element-color/element-color.component.html",
"approved": false,

"issues": [
{
"type": "best-practice",
"severity": "medium",
"description": "The card elements are currently duplicated for both background and text colors. Consider abstracting this into a reusable component to improve maintainability and readability.",
"recommendedFix": "Create a reusable ColorCard component that accepts props for title and color classes. This minimizes duplication and adheres to DRY principles.",
"codeFix": "import ColorCard from './ColorCard';\n\n<ColorCard title='Background Color' colorClasses={['bg-blue-100', 'bg-blue-200', 'bg-blue-300', 'bg-blue-400', 'bg-blue-500', 'bg-blue-600', 'bg-blue-700', 'bg-blue-800', 'bg-blue-900']} />\n<ColorCard title='Text Color' colorClasses={['text-blue-100', 'text-blue-200', 'text-blue-300', 'text-blue-400', 'text-blue-500', 'text-blue-600', 'text-blue-700', 'text-blue-800', 'text-blue-900']} />"
}
]
}

[phoenixcoded20]

{
"file": "src/app/demo/elements/element-color/element-color.component.ts",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "The property 'styleUrl' is incorrectly spelled as 'styleUrl' instead of 'styleUrls', which prevents the component from correctly loading its styles.",
"recommendedFix": "Change 'styleUrl' to 'styleUrls' to ensure the styles are applied correctly.",
"codeFix": "typescript\n styleUrls: ['./element-color.component.scss']\n"
}
]
}

[phoenixcoded20]

{
"file": "src/app/demo/elements/typography/typography.component.html",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "The HTML class names have inconsistent spacing. The class "m-t-0" should be "mt-0" to conform with Bootstrap class naming conventions.",
"recommendedFix": "Change all instances of "m-t-0" to "mt-0".",
"codeFix": "<p class="lead mt-0">Your title goes here

\n<p class="text-muted mb-30">Your awesome text goes here.

\n<p class="text-muted mb-15 mt-20">Add\n.text-end\nfor a blockquote with right-aligned content.

\n<ul class="list-inline mb-0">\n<li class="list-inline-item">Lorem ipsum\n<li class="list-inline-item">Phasellus iaculis\n<li class="list-inline-item">Nulla volutpat\n"
}
]
}

[phoenixcoded20]

{
"file": "src/app/demo/elements/typography/typography.component.ts",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "The 'styleUrls' property is incorrectly named as 'styleUrl'. This will cause the component's styles to not be loaded.",
"recommendedFix": "Change 'styleUrl' to 'styleUrls' to correctly reference the styles for this component.",
"codeFix": "typescript\n styleUrls: ['./typography.component.scss']\n"
}
]
}

[phoenixcoded20]

{
"file": "src/app/demo/other/sample-page/sample-page.component.ts",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "The property 'styleUrl' is incorrectly defined. The correct property should be 'styleUrls' with an 's' at the end.",
"recommendedFix": "Change 'styleUrl' to 'styleUrls' to correctly apply the styles in Angular.",
"codeFix": "diff\n- styleUrl: './sample-page.component.scss'\n+ styleUrls: ['./sample-page.component.scss']\n"
}
]
}

[phoenixcoded20]

{
"file": "src/app/demo/pages/authentication/login/login.component.html",
"approved": false,

"issues": [
{
"type": "best-practice",
"severity": "medium",
"description": "Using 'javascript:void(0)' is generally not recommended for anchors as it can cause issues with accessibility and SEO. It's better to use a button element for actions that do not navigate.",
"recommendedFix": "Replace the 'a' elements that do not link to a valid URL with 'button' elements.",
"codeFix": "<button class="d-flex justify-content-center" type="button">\n <img src="assets/images/logo-dark.svg" alt="logo" />\n\n<h5 class="text-secondary">\n <button type="button" class="text-secondary">Forgot Password?\n"
}
]
}

[phoenixcoded20]

{
"file": "src/app/demo/pages/authentication/login/login.component.ts",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "medium",
"description": "The property 'styleUrl' is incorrectly spelled. It should be 'styleUrls' as specified in Angular component metadata.",
"recommendedFix": "Change 'styleUrl' to 'styleUrls' for correct Angular component configuration.",
"codeFix": "- styleUrl: './login.component.scss'\n+ styleUrls: ['./login.component.scss']"
}
]
}

[phoenixcoded20]

{
"file": "src/app/demo/pages/authentication/register/register.component.html",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "The same id 'floatingInput' is being used for multiple input fields, which violates HTML standards. This can lead to unexpected behavior when accessing these inputs via JavaScript or CSS.",
"recommendedFix": "Each input element should have a unique id to prevent conflicts.",
"codeFix": "<input type="email" class="form-control" id="floatingInputFirstName" placeholder="Enter Your First Name"\n [formField]="registerForm.firstName"\n [class.is-invalid]="submitted() && registerForm.firstName().errors().length > 0" />\n<label for="floatingInputFirstName">First Name\n<input type="email" class="form-control" id="floatingInputLastName" placeholder="Enter Your Last Name"\n [formField]="registerForm.lastName"\n [class.is-invalid]="submitted() && registerForm.lastName().errors().length > 0" />\n<label for="floatingInputLastName">Last Name\n<input type="email" class="form-control" id="floatingInputEmail"\n [class.is-invalid]="submitted() && registerForm.email().invalid()" placeholder="Email Address"\n [formField]="registerForm.email" />\n<label for="floatingInputEmail">Email address / Username\n<input type="password" id="floatingInputPassword" class="form-control" [formField]="registerForm.password"\n [class.is-invalid]="submitted() && registerForm.password().errors().length > 0" placeholder="Password (min. 8 characters)" />\n<label for="floatingInputPassword">Password"
}
]
}

[phoenixcoded20]

{
"file": "src/app/demo/pages/authentication/register/register.component.ts",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "The property 'styleUrl' is incorrectly spelled. It should be 'styleUrls'. This will likely lead to issues with styles not being applied correctly.",
"recommendedFix": "Change 'styleUrl' to 'styleUrls' to ensure styles are applied properly.",
"codeFix": "@component({\n selector: 'app-register',\n imports: [CommonModule, RouterModule, FormField],\n templateUrl: './register.component.html',\n styleUrls: ['./register.component.scss']\n})"
}
]
}

[phoenixcoded20]

{
"file": "src/app/theme/layout/admin/admin.component.html",
"approved": false,

"issues": [
{
"type": "best-practice",
"severity": "low",
"description": "The absence of a newline at the end of the file can lead to issues in certain environments and is generally not a best practice.",
"recommendedFix": "Add a newline at the end of the file to follow standard practices.",
"codeFix": "This line should be added at the end:\n\n\n"
}
]
}

[phoenixcoded20]

{
"file": "src/app/theme/layout/admin/admin.component.ts",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "The import of LayoutStateService was replaced with ConfigService, which may not provide the expected state management functionality required by the AdminComponent. This could lead to issues in layout state management.",
"recommendedFix": "Revert the change to ensure that the intended layout state management functionality remains intact.",
"codeFix": "- import { ConfigService } from '../../shared/service/config.service';\n+ import { LayoutStateService } from '../../shared/service/layout-state.service';"
}
]
}

[phoenixcoded20]

{
"file": "src/app/theme/layout/admin/configuration/configuration.component.html",
"approved": false,

"issues": [
{
"type": "best-practice",
"severity": "medium",
"description": "Using javascript:void(0) in href attributes is less semantically correct. It is better to use preventDefault() to avoid default link behavior. This improves accessibility and clarity of intention.",
"recommendedFix": "Replace the link with a button element or use preventDefault() for clarity and better semantics.",
"codeFix": "<a href="" (click)="styleSelectorToggle = !styleSelectorToggle; $event.preventDefault()">\n <i class="ph-duotone ph-gear-six">\n "
}
]
}

[phoenixcoded20]

{
"file": "src/app/theme/layout/admin/configuration/configuration.component.ts",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "The property 'styleUrl' is a typo; the correct property in Angular component metadata should be 'styleUrls'. This will cause the component styles not to load correctly.",
"recommendedFix": "Change 'styleUrl' to 'styleUrls' in the component metadata.",
"codeFix": " styleUrls: ['./configuration.component.scss']"
}
]
}

[phoenixcoded20]

{
"file": "src/app/theme/layout/admin/nav-bar/nav-bar.component.ts",
"approved": false,
"issues": [
{
"type": "best-practice",
"severity": "medium",
"description": "The property 'styleUrl' is incorrectly named and should be 'styleUrls' as per Angular's conventions. This could lead to the styles not being applied correctly to the component.",
"recommendedFix": "Change 'styleUrl' to 'styleUrls' to follow Angular naming conventions.",
"codeFix": "@@ -2,7 +2,7 @@\n- styleUrls: ['./nav-bar.component.scss']\n+ styleUrls: ['./nav-bar.component.scss']"
}
]
}

[phoenixcoded20]

{
"file": "src/app/theme/layout/admin/nav-bar/nav-left/nav-left.component.html",
"approved": false,

"issues": [
{
"type": "best-practice",
"severity": "medium",
"description": "Using 'javascript:' as a href value is not a best practice as it can lead to unexpected behavior and is not valid HTML. Instead, 'javascript:void(0)' is more appropriate for preventing navigation while remaining valid.",
"recommendedFix": "Replace 'href="javascript:"' with 'href="javascript:void(0)"' to ensure valid HTML and prevent potential issues.",
"codeFix": "html\n<a href=\"javascript:void(0)\" class=\"pc-head-link head-link-secondary ms-0 mobile-menu\" id=\"mobile-collapse mobile-collapse1\" (click)=\"navCollapsedMob()\">\n"
},
{
"type": "nit",
"severity": "low",
"description": "The closing div tag does not have a newline at the end of the file, which is a common practice for code cleanliness and helps with version control diffs.",
"recommendedFix": "Add a newline at the end of the file to improve code cleanliness.",
"codeFix": "html\n+</div>\n+\\ No newline at end of file\n"
}
]
}

[phoenixcoded20]

{
"file": "src/app/theme/layout/admin/nav-bar/nav-left/nav-left.component.ts",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "There is a typo in the property name 'styleUrl'. It should be 'styleUrls' to properly apply the styles to the component.",
"recommendedFix": "Change 'styleUrl' to 'styleUrls' to ensure the styles are loaded correctly.",
"codeFix": " styleUrls: ['./nav-left.component.scss']"
}
]
}

[phoenixcoded20]

{
"file": "src/app/theme/layout/admin/nav-bar/nav-logo/nav-logo.component.html",
"approved": false,
"issues": [
{
"type": "bug",
"severity": "medium",
"description": "The method navCollapsed is being invoked as a function (navCollapsed()), which suggests it may have side effects and not return a boolean value. It should be used as a property instead (navCollapsed) if it's a boolean.",
"recommendedFix": "Use navCollapsed directly instead of invoking it as a function to ensure correct evaluation.",
"codeFix": "<a href="javascript:void(0)" class="pc-head-link head-link-secondary m-0 mobile-menu"\n [ngClass]="{ on: navCollapsed }" id="sidebar-hide mobile-collapse" (click)="navCollapse()"\n title="Click to Menu Collapse">"
}
]
}

[phoenixcoded20]

{
"file": "src/app/theme/layout/admin/nav-bar/nav-logo/nav-logo.component.ts",
"approved": false,

"issues": [
{
"type": "bug",
"severity": "high",
"description": "The use of 'model' instead of '@input' for 'navCollapsed' is incorrect. This will prevent the input property from functioning as intended, hence breaking the component's functionality.",
"recommendedFix": "Change 'navCollapsed' back to use '@input()' decorator to ensure it receives the correct input from the parent component.",
"codeFix": "@input() navCollapsed = false;"
},
{
"type": "bug",
"severity": "high",
"description": "The use of 'output' instead of '@output' for 'NavCollapse' is incorrect. This will prevent the event emitter from functioning as intended.",
"recommendedFix": "Change 'NavCollapse' back to use '@output()' decorator to ensure it correctly emits the collapse event.",
"codeFix": "@output() NavCollapse = new EventEmitter();"
},
{
"type": "improvement",
"severity": "medium",
"description": "The 'navCollapse' method directly updates 'navCollapsed' which is set as a model. This can lead to confusion as 'navCollapsed' should reflect state from input, and not be updated directly through a method in this way.",
"recommendedFix": "Simplify the logic to toggle 'navCollapsed' based on its current state without using 'update'.",
"codeFix": "this.navCollapsed = !this.navCollapsed;"
}
]
}

[phoenixcoded20]

{
"file": "src/app/theme/layout/admin/nav-bar/nav-right/nav-right.component.html",
"approved": false,
"issues": [
{
"type": "bug",
"severity": "high",
"description": "Use of href='javascript:void(0)' can lead to accessibility issues and does not provide a meaningful URL. It is better to use buttons or links that trigger actions without specifying an href that does not navigate.",
"recommendedFix": "Replace 'javascript:void(0)' with a button element or an appropriate anchor that uses an event handler for toggling dropdowns.",
"codeFix": "\n \n \n \n \n \n "
},
{
"type": "bug",
"severity": "high",
"description": "Multiple instances of 'href='javascript:void(0)'' used in the dropdown items for actions that should not have href attributes, risking both functionality and accessibility.",
"recommendedFix": "These links should either be changed to buttons with appropriate event handlers or handled using safe links that perform no navigation.",
"codeFix": "\n \n Account Profile\n \n \n \n Social Profile\n \n \n \n Logout\n "
}
]
}