Skip to content

Fix merging of properties type and description #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
progval wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix merging of properties type and description #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c58d1ca
Update properties_to_json.py
progval Jan 17, 2026
0eb4764
Refactor the merging logic to work
meldra Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion scripts/properties_to_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,26 @@
# Look for a similar existing item from a newer CodeMeta version
for existing_item in json_items:
if existing_item.items() >= item.items():
# We found an existing item, add this version to its list
# We found an identical existing item, add this version to its list
assert (
version not in existing_item["versions"]
), f"CodeMeta {version} has duplicated property {item}"
existing_item["versions"].append(version)
# check for existing properties that have differing types or descriptions
# values from newer versions of properties_description.json take precedence
# over new ones.
# update the versions for these here and break to avoid duplicate rows
if item["Property"] == existing_item["Property"]:
if item["Type"] != existing_item["Type"]:
item["Type"] = existing_item["Type"]
if version not in existing_item["versions"]:
existing_item["versions"].append(version)
if item["Description"] != existing_item["Description"]:
item["Description"] = existing_item["Description"]
if version not in existing_item["versions"]:
existing_item["versions"].append(version)
break

else:
# No similar item, create a new one
item["versions"] = [version]
Expand Down