WIP - Automatically fail context on exception#176
Open
matas-zanevicius wants to merge 3 commits intocollectiveidea:masterfrom
Open
WIP - Automatically fail context on exception#176matas-zanevicius wants to merge 3 commits intocollectiveidea:masterfrom
matas-zanevicius wants to merge 3 commits intocollectiveidea:masterfrom
Conversation
|
@matas-zanevicius this looks awesome. Would you mind looking at the merge conflict? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the reason for this feature?
Sometimes we may have a situation where our interactors should fail in case there is an exception raised. Currently, we have to rescue exceptions in order to fail the context. consider the following example:
This example above is simple, but it may get more complex when you have to rescue multiple different exceptions in the same interactor class in different places. However, what you actually want is to fail the context on those exceptions. And perhaps log them, so that they don't halt your program, but don't go unnoticed either.
My proposal: define what kinds of exceptions must be rescued, and provide a proc, if necessary, with custom behaviour for rescued exception(s) handling.
NameErroris silly, I only use it to make my example obvious. In real life, you would probably rescue from some other errors or your own custom error...