fix(graphql-codegen): re-export models and custom operations from index.ts #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex.ts
The generated index.ts was importing models but not re-exporting them,
breaking backwards compatibility for code that imports models directly:
import { DatabaseModel, TableModel } from '@constructive-db/constructive-sdk';
This adds:
- export * from './models' to re-export all model classes
- export { createQueryOperations } from './query' (when queries exist)
- export { createMutationOperations } from './mutation' (when mutations exist)
This maintains backwards compatibility while still supporting the new
createClient() API.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes backwards compatibility for code that imports model classes directly from the SDK:
The generated
index.tswas importing models but not re-exporting them, causing TypeScript errors like:This adds the following re-exports to the generated index.ts:
export * from './models'- all model classesexport { createQueryOperations } from './query'- when queries existexport { createMutationOperations } from './mutation'- when mutations existUpdates since last revision
client-generator.test.ts.snapto reflect the new export statementsReview & Testing Checklist for Human
pnpm run generate:sdk) and verify the tests pass (pnpm testin application/app)./select-typesor./clientindex.tsincludes the new export statementsNotes
Link to Devin run: https://app.devin.ai/sessions/475ee077a17e4f02b2b71f5aeba11854
Requested by: Dan Lynch (@pyramation)