refactor: migrate container_run_network_windows_test.go to nerdtest.Setup#5014
Draft
takumi12311123 wants to merge 1 commit into
Draft
refactor: migrate container_run_network_windows_test.go to nerdtest.Setup#5014takumi12311123 wants to merge 1 commit into
takumi12311123 wants to merge 1 commit into
Conversation
…etup Refactor the test cases in container_run_network_windows_test.go to use the Tigron framework (nerdtest.Setup). TestRunPort is left as-is because it only delegates to baseTestRunPort, shared with container_run_network_base_test.go and migrated separately. Signed-off-by: Takumi Akasaka <takumiakasaka1231@gmail.com>
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the test cases in
cmd/nerdctl/container/container_run_network_windows_test.goto use the Tigron framework (nerdtest.Setup).TestRunPortis left as-is because it only delegates tobaseTestRunPort(defined incontainer_run_network_base_test.go), which is shared with the Linux test and will be migrated together with that file.Note: this is a Windows-only test file; verified locally with
gofmt,GOOS=windows go vet, andgolangci-lint, but test execution will be exercised by CI on a Windows runner.related : #4613