storage: fix UID/GID map handling for shifting layers#734
Open
giuseppe wants to merge 2 commits intocontainers:mainfrom
Open
storage: fix UID/GID map handling for shifting layers#734giuseppe wants to merge 2 commits intocontainers:mainfrom
giuseppe wants to merge 2 commits intocontainers:mainfrom
Conversation
Remove the canUseShifting branch from CreateContainer and always store the caller's IDMappingOptions. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
when the driver supports shifting, set the rechown target to identity instead of the container's maps. Closes: https://redhat.atlassian.net/browse/RHEL-160859 Assisted-by: Claude Opus 4.6 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Contributor
|
Note to self: Also #735. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the driver supports shifting, set the rechown target to identity instead of the container's maps.
Closes: https://redhat.atlassian.net/browse/RHEL-160859
Assisted-by: Claude Opus 4.6
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com