[debug] show dump.log on criu_dump error

[kolyshkin]

This is to debug CentOS Stream 9 C/R failures.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the debugging process for CRIU checkpointing failures by automatically printing critical error information from the CRIU log file directly to the console upon an unsuccessful dump. This enhancement provides immediate diagnostic feedback, streamlining the identification and resolution of issues, especially those encountered on CentOS Stream 9.

Highlights

• Enhanced CRIU Error Reporting: Implemented a mechanism to automatically display relevant error messages from the CRIU dump log (dump.log) to the console when a CRIU checkpointing operation fails. This is achieved by executing a grep command that searches for 'Error' and shows preceding lines.
• Improved Debugging Experience: The change directly addresses debugging challenges, particularly for CentOS Stream 9 Checkpoint/Restore (C/R) failures, by providing immediate visibility into CRIU-specific errors without manual log inspection.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a debugging feature to show the CRIU log on dump errors. However, the implementation uses system() with a potentially user-controlled path, which introduces a critical command injection vulnerability. My review includes a suggestion to replace this with a safer fork() and execvp() pattern to mitigate the security risk.

[gemini-code-assist]

Using system() with a command string constructed from cr_options->work_path introduces a command injection vulnerability. If work_path contains shell metacharacters, it could lead to arbitrary command execution. It is much safer to use fork() and execvp() to avoid invoking a shell.

    pid_t pid = fork();
    if (pid == 0) {
        cleanup_free char *path = NULL;
        xasprintf(&path, "%s/%s", cr_options->work_path, CRIU_CHECKPOINT_LOG_FILE);
        char *const args[] = {"grep", "-n", "-B5", "Error", path, NULL};
        execvp(args[0], args);
        _exit(127);
    }
    if (pid > 0) {
        waitpid(pid, NULL, 0);
    }

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.