Skip to content

[v4.2.0-rhel] Fix bug in sdnotifiy test#28509

Merged
lsm5 merged 1 commit intocontainers:v4.2.0-rhelfrom
cevich:fix_sdnotifytest
Apr 15, 2026
Merged

[v4.2.0-rhel] Fix bug in sdnotifiy test#28509
lsm5 merged 1 commit intocontainers:v4.2.0-rhelfrom
cevich:fix_sdnotifytest

Conversation

@cevich
Copy link
Copy Markdown
Member

@cevich cevich commented Apr 14, 2026

Commit 75c7a0d changed the variable name for a helper container image, but missed one reference. This causes the test to fail at the end. Fix this by using the correct variable name.

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

Commit 75c7a0d changed the variable name for a helper container
image, but missed one reference.  This causes the test to fail at the
end.  Fix this by using the correct variable name.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Copy link
Copy Markdown
Member Author

cevich commented Apr 14, 2026

@TomSweeneyRedHat not sure if this also afflicts any of the branches you're working on. I'm also unsure why I didn't notice it before 😞

@cevich
Copy link
Copy Markdown
Member Author

cevich commented Apr 14, 2026

Example of the sdnotify test failure and several knock-on failures caused by unexpected "extra" image presence.

output.txt

@Luap99 Luap99 changed the title Fix bug in sdnotifiy test [v4.2.0-rhel] Fix bug in sdnotifiy test Apr 14, 2026
Copy link
Copy Markdown
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat PTAL

@lsm5
Copy link
Copy Markdown
Member

lsm5 commented Apr 15, 2026

tiny nit: typo in commit message title sdnotifiy .

@lsm5 lsm5 merged commit 2440195 into containers:v4.2.0-rhel Apr 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants