Updates & maintenance #40
Open
+413
−626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade PHP requirement to 8.2+ and Nette to 3.2+ - Replace ninjify packages with contributte/qa and contributte/phpstan - Update phpstan.neon to use contributte ruleset with level 9 - Update ruleset.xml to use contributte/qa ruleset - Replace single main.yaml workflow with separate workflow files (tests, phpstan, codesniffer, coverage) - Rename tests/cases to tests/Cases and tests/fixtures to tests/Fixtures - Update source files to use PHP 8.2 typed properties - Update tests/bootstrap.php to use native Nette Tester - Remove obsolete .kodiak.toml and .coveralls.yml files
- Add mockery/mockery to dev dependencies - Add workflow_dispatch trigger to all workflows - Add weekly schedule trigger to tests workflow
- Fix PHPStan level 9 issues: - Update deprecated Form constants (MIN->Min, MAX->Max, RANGE->Range, DATA_TEXT->DataText) - Replace deprecated getSeparatorPrototype() with getContainerPrototype() - Replace deprecated IControl interface with Control - Add typed properties to all classes - Add native type hints to all methods - Fix setValue() contravariance issue in ProtectionFastInput - Fix CodeSniffer issues: - Add array type to $wrappers properties - Add proper PHPDoc annotations - Fix method spacing and ordering - Add exclusion rules for inherited property types - Update phpstan.neon and ruleset.xml with appropriate ignores
- Update phpstan.neon with scanDirectories and fileExtensions - Update Makefile with GitHub Actions conditional formatting - Fix .editorconfig glob pattern syntax - Clean .gitattributes format - Update .gitignore with comprehensive test artifact patterns - Update workflows to use @master and proper PHP versions - Add multi-PHP version testing (8.2, 8.3, 8.4, lowest) - Fix CodeSniffer issues in AbstractDateTimeInput.php - Update test expected files to match actual output
f3l1x
commented
Dec 25, 2025
tests/bootstrap.php
Outdated
| <?php declare(strict_types = 1); | ||
|
|
||
| use Ninjify\Nunjuck\Environment; | ||
| use Tester\Environment; |
Member
Author
There was a problem hiding this comment.
It's total wrong. Do it whole file again.
Makefile
Outdated
| @@ -1,24 +1,29 @@ | |||
| .PHONY: install qa cs csf phpstan tests coverage-clover coverage-html | |||
| .PHONY: install qa cs csf phpstan tests coverage | |||
- Add PHP 8.5 to tests workflow matrix - Remove explicit php version from coverage workflow - Add contributte/tester dependency and use Environment::setup() - Rewrite Makefile with proper .PHONY declarations per target - Convert closures to arrow functions in test files (auto-fixed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.