Open
Conversation
Signed-off-by: Felipe Zipitria <[email protected]>
Deploying crs-documentation with
|
| Latest commit: |
9f10c39
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca8ecd58.documentation-km5.pages.dev |
| Branch Preview URL: | https://chore-add-early-blocking-doc.documentation-km5.pages.dev |
Xhoenix
reviewed
Jun 19, 2025
Xhoenix
reviewed
Jun 19, 2025
Xhoenix
reviewed
Jun 19, 2025
Co-authored-by: Xhoenix <[email protected]>
theseion
reviewed
Jun 20, 2025
Comment on lines
+18
to
+19
| > **Enable early execution of phase 1 rules** | ||
| > By default, ModSecurity does **not** activate this flag. Phase 1 rules run **after** the request headers are fully read. This flag allows certain phase 1 rules to trigger *earlier*, potentially before the full header set is available. |
Contributor
There was a problem hiding this comment.
I think this is the wrong way around. @airween? Didn't the issue say they used --disable-request-early?
Contributor
There was a problem hiding this comment.
Yes, @theseion is right. I think we should suggest don't use --disable-request-early flag.
Member
Author
There was a problem hiding this comment.
Ugh. Is it just the name, or the behavior completely changes? Can you point me to the docs?
Contributor
There was a problem hiding this comment.
I just found this one:
Starting with ModSecurity 2.7.0 there are a few important configuration options
- --enable-request-early - On ModSecurity 2.6 phase one has been moved to phase 2 hook, if you want to play around it use this option.
But in configure.ac, the logic is in opposite direction:
if test "$enableval" != "no"; then
request_early="-DREQUEST_EARLY"
MODSEC_EXTRA_CFLAGS="$MODSEC_EXTRA_CFLAGS $request_early"
else
request_early=
fi
],
[
request_early='-DREQUEST_EARLY'
The logic:
- if the user passes this option, and the value is not
no(which equals with--disable-request-early, then feature will be turned ON - if the user does not pass this option, then the build script assumes it's necessary and will be turned ON
Member
There was a problem hiding this comment.
Ping @coreruleset/core-developers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Fixes #221