fix: code generation always reads and writes files as UTF-8 - #1303
Open
gennaroprota wants to merge 1 commit into
Open
gennaroprota wants to merge 1 commit into
gennaroprota wants to merge 1 commit into
Conversation
Contributor
🧾 Changes by Scope
🔝 Top Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1303 +/- ##
========================================
Coverage 83.12% 83.12%
========================================
Files 35 35
Lines 3662 3662
Branches 844 844
========================================
Hits 3044 3044
Misses 410 410
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gennaroprota
force-pushed
the
fix/code_generation_always_reads_and_writes_files_as_utf8
branch
from
September 14, 2026 13:26
ec9229c to
ba18db3
Compare
|
An automated preview of the documentation is available at https://1303.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-09-18 15:29:30 UTC |
The scripts under utils/codegen opened every file without specifying an encoding, so Python used the locale's preferred one: the ANSI codepage on Windows, UTF-8 elsewhere. Use UTF-8 everywhere, instead. Closes cppalliance#1310.
gennaroprota
force-pushed
the
fix/code_generation_always_reads_and_writes_files_as_utf8
branch
from
September 18, 2026 15:20
ba18db3 to
318a5df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scripts under utils/codegen opened every file without specifying an encoding, so Python used the locale's preferred one: the ANSI codepage on Windows, UTF-8 elsewhere.
Use UTF-8 everywhere, instead.
Changes
Testing
No new test. The behavior is already covered by
schema-check.Documentation
Not needed. Nothing user-visible changes, and no page describes what encoding the generators use.
Closes #1310.